Changeset 35186 for trunk/tests/phpunit/tests/query/postStatus.php

Timestamp:

10/15/2015 04:43:37 AM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/query/postStatus.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/postStatus.php

@@ -12 +12 @@
         public static $author_privatefoo_post;
 
-        public static function setUpBeforeClass() {
-                $f = new WP_UnitTest_Factory;
-
-                self::$editor_user = $f->user->create( array( 'role' => 'editor' ) );
-                self::$author_user = $f->user->create( array( 'role' => 'author' ) );
-
-                self::$editor_private_post = $f->post->create( array( 'post_author' => self::$editor_user, 'post_status' => 'private' ) );
-                self::$author_private_post = $f->post->create( array( 'post_author' => self::$author_user, 'post_status' => 'private' ) );
+        public static function wpSetUpBeforeClass( $factory ) {
+                self::$editor_user = $factory->user->create( array( 'role' => 'editor' ) );
+                self::$author_user = $factory->user->create( array( 'role' => 'author' ) );
+
+                self::$editor_private_post = $factory->post->create( array( 'post_author' => self::$editor_user, 'post_status' => 'private' ) );
+                self::$author_private_post = $factory->post->create( array( 'post_author' => self::$author_user, 'post_status' => 'private' ) );
 
                 // Custom status with private=true.
                 register_post_status( 'privatefoo', array( 'private' => true ) );
-                self::$editor_privatefoo_post = $f->post->create( array( 'post_author' => self::$editor_user, 'post_status' => 'privatefoo' ) );
-                self::$author_privatefoo_post = $f->post->create( array( 'post_author' => self::$author_user, 'post_status' => 'privatefoo' ) );
+                self::$editor_privatefoo_post = $factory->post->create( array( 'post_author' => self::$editor_user, 'post_status' => 'privatefoo' ) );
+                self::$author_privatefoo_post = $factory->post->create( array( 'post_author' => self::$author_user, 'post_status' => 'privatefoo' ) );
                 _unregister_post_status( 'privatefoo' );
-
-                self::commit_transaction();
-        }
-
-        public static function tearDownAfterClass() {
+        }
+
+        public static function wpTearDownAfterClass() {
                 if ( is_multisite() ) {
                         wpmu_delete_user( self::$editor_user );
@@ -43 +39 @@
                 wp_delete_post( self::$editor_privatefoo_post, true );
                 wp_delete_post( self::$author_privatefoo_post, true );
-
-                self::commit_transaction();
         }