Changeset 35186 for trunk/tests/phpunit/tests/query/results.php

Timestamp:

10/15/2015 04:43:37 AM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/query/results.php (modified) (3 diffs)

trunk/tests/phpunit/tests/query/results.php

@@ -23 +23 @@
         static $child_four;
 
-        public static function setUpBeforeClass() {
-                $factory = new WP_UnitTest_Factory;
-
+        public static function wpSetUpBeforeClass( $factory ) {
                 self::$cat_ids[] = $cat_a = $factory->term->create( array( 'taxonomy' => 'category', 'name' => 'cat-a' ) );
                 self::$cat_ids[] = $cat_b = $factory->term->create( array( 'taxonomy' => 'category', 'name' => 'cat-b' ) );
@@ -68 +66 @@
                 self::$post_ids[] = self::$child_three = $factory->post->create( array( 'post_title' => 'child-three', 'post_parent' => self::$parent_two, 'post_date' => '2007-01-01 00:00:03' ) );
                 self::$post_ids[] = self::$child_four = $factory->post->create( array( 'post_title' => 'child-four', 'post_parent' => self::$parent_two, 'post_date' => '2007-01-01 00:00:04' ) );
-
-                self::commit_transaction();
-        }
-
-        public static function tearDownAfterClass() {
+        }
+
+        public static function wpTearDownAfterClass() {
                 foreach ( self::$cat_ids as $cat_id ) {
                         wp_delete_term( $cat_id, 'category' );
@@ -84 +80 @@
                         wp_delete_post( $post_id, true );
                 }
-
-                self::commit_transaction();
         }