Changeset 35186 for trunk/tests/phpunit/tests/query/stickies.php

Timestamp:

10/15/2015 04:43:37 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/query/stickies.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/stickies.php

@@ -9 +9 @@
     static $posts = array();
 
-    public static function setUpBeforeClass() {
-        $f = new WP_UnitTest_Factory();
-
+    public static function wpSetUpBeforeClass( $factory ) {
         // Set post times to get a reliable order.
         $now = time();
         for ( $i = 0; $i <= 22; $i++ ) {
             $post_date = date( 'Y-m-d H:i:s', $now - ( 10 * $i ) );
-            self::$posts[ $i ] = $f->post->create( array(
+            self::$posts[ $i ] = $factory->post->create( array(
                 'post_date' => $post_date,
             ) );
@@ -24 +22 @@
         stick_post( self::$posts[14] );
         stick_post( self::$posts[8] );
-
-        self::commit_transaction();
     }
 
-    public static function tearDownAfterClass() {
+    public static function wpTearDownAfterClass() {
         foreach ( self::$posts as $p ) {
             wp_delete_post( $p, true );
         }
-
-        self::commit_transaction();
     }