Changeset 35186 for trunk/tests/phpunit/tests/user/listAuthors.php

Timestamp:

10/15/2015 04:43:37 AM (5 years ago)

Author:

wonderboymusic

Message:

Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.

This makes it way easier to add fixtures, and tear them down, without needing to instantiate WP_UnitTest_Factory in every class - removes the need to call commit_transaction() in each individual class.

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/user/listAuthors.php (modified) (3 diffs)

trunk/tests/phpunit/tests/user/listAuthors.php

@@ -24 +24 @@
         'html'          => true );
         */
-    public static function setUpBeforeClass() {
-        $factory = new WP_UnitTest_Factory;
-
+    public static function wpSetUpBeforeClass( $factory ) {
         self::$users[] = $factory->user->create( array( 'user_login' => 'zack', 'display_name' => 'zack', 'role' => 'author', 'first_name' => 'zack', 'last_name' => 'moon' ) );
         self::$users[] = $factory->user->create( array( 'user_login' => 'bob', 'display_name' => 'bob', 'role' => 'author', 'first_name' => 'bob', 'last_name' => 'reno' ) );
@@ -41 +39 @@
             self::$user_urls[] = get_author_posts_url( $userid );
         }
-
-        self::commit_transaction();
     }
 
-    public static function tearDownAfterClass() {
+    public static function wpTearDownAfterClass() {
         foreach ( array_merge( self::$users, array( self::$fred_id ) ) as $user_id ) {
             if ( is_multisite() ) {
@@ -57 +53 @@
             wp_delete_post( $post_id, true );
         }
-
-        self::commit_transaction();
     }