Changeset 35192

Timestamp:

10/15/2015 05:56:47 AM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: in Tests_Comment_Query::test_get_comments_for_post(), create fewer comments (5, instead of 10).

See #30017, #33968.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (5 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -536 +536 @@
 
     function test_get_comments_for_post() {
+        $limit = 5;
+
         $post_id = $this->factory->post->create();
-        $this->factory->comment->create_post_comments( $post_id, 10 );
+        $this->factory->comment->create_post_comments( $post_id, $limit );
         $comments = get_comments( array( 'post_id' => $post_id ) );
-        $this->assertEquals( 10, count( $comments ) );
+        $this->assertEquals( $limit, count( $comments ) );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id, $comment->comment_post_ID );
@@ -545 +547 @@
 
         $post_id2 = $this->factory->post->create();
-        $this->factory->comment->create_post_comments( $post_id2, 10 );
+        $this->factory->comment->create_post_comments( $post_id2, $limit );
         $comments = get_comments( array( 'post_id' => $post_id2 ) );
-        $this->assertEquals( 10, count( $comments ) );
+        $this->assertEquals( $limit, count( $comments ) );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id2, $comment->comment_post_ID );
@@ -553 +555 @@
 
         $post_id3 = $this->factory->post->create();
-        $this->factory->comment->create_post_comments( $post_id3, 10, array( 'comment_approved' => '0' ) );
+        $this->factory->comment->create_post_comments( $post_id3, $limit, array( 'comment_approved' => '0' ) );
         $comments = get_comments( array( 'post_id' => $post_id3 ) );
-        $this->assertEquals( 10, count( $comments ) );
+        $this->assertEquals( $limit, count( $comments ) );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );
@@ -561 +563 @@
 
         $comments = get_comments( array( 'post_id' => $post_id3, 'status' => 'hold' ) );
-        $this->assertEquals( 10, count( $comments ) );
+        $this->assertEquals( $limit, count( $comments ) );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );
@@ -569 +571 @@
         $this->assertEquals( 0, count( $comments ) );
 
-        $this->factory->comment->create_post_comments( $post_id3, 10, array( 'comment_approved' => '1' ) );
+        $this->factory->comment->create_post_comments( $post_id3, $limit, array( 'comment_approved' => '1' ) );
         $comments = get_comments( array( 'post_id' => $post_id3 ) );
-        $this->assertEquals( 20, count( $comments ) );
+        $this->assertEquals( $limit * 2, count( $comments ) );
         foreach ( $comments as $comment ) {
             $this->assertEquals( $post_id3, $comment->comment_post_ID );