Make WordPress Core


Ignore:
Timestamp:
10/16/2015 09:04:12 PM (9 years ago)
Author:
wonderboymusic
Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/comment/checkComment.php

    r32519 r35225  
    3232
    3333    public function test_should_return_true_when_comment_whitelist_is_enabled_and_author_has_approved_comment() {
    34         $post_id = $this->factory->post->create();
     34        $post_id = self::$factory->post->create();
    3535        $prev_args = array(
    3636            'comment_post_ID'      => $post_id,
     
    4040            'comment_author'       => 'BobtheBuilder',
    4141        );
    42         $prev_comment_id = $this->factory->comment->create( $prev_args );
     42        $prev_comment_id = self::$factory->comment->create( $prev_args );
    4343
    4444        update_option( 'comment_whitelist', 1 );
Note: See TracChangeset for help on using the changeset viewer.