WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/16/2015 09:04:12 PM (6 years ago)
Author:
wonderboymusic
Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/comment/getCommentCount.php

    r33822 r35225  
    1515
    1616    public function test_get_comment_count_approved() {
    17         $this->factory->comment->create( array(
     17        self::$factory->comment->create( array(
    1818            'comment_approved' => 1
    1919        ) );
     
    3030
    3131    public function test_get_comment_count_awaiting() {
    32         $this->factory->comment->create( array(
     32        self::$factory->comment->create( array(
    3333            'comment_approved' => 0
    3434        ) );
     
    4545
    4646    public function test_get_comment_count_spam() {
    47         $this->factory->comment->create( array(
     47        self::$factory->comment->create( array(
    4848            'comment_approved' => 'spam'
    4949        ) );
     
    6060
    6161    public function test_get_comment_count_trash() {
    62         $this->factory->comment->create( array(
     62        self::$factory->comment->create( array(
    6363            'comment_approved' => 'trash'
    6464        ) );
     
    7575
    7676    public function test_get_comment_count_post_trashed() {
    77         $this->factory->comment->create( array(
     77        self::$factory->comment->create( array(
    7878            'comment_approved' => 'post-trashed'
    7979        ) );
Note: See TracChangeset for help on using the changeset viewer.