WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/16/2015 09:04:12 PM (6 years ago)
Author:
wonderboymusic
Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/customize/section.php

    r32658 r35225  
    136136     */
    137137    function test_check_capabilities() {
    138         $user_id = $this->factory->user->create( array( 'role' => 'administrator' ) );
     138        $user_id = self::$factory->user->create( array( 'role' => 'administrator' ) );
    139139        wp_set_current_user( $user_id );
    140140
     
    162162     */
    163163    function test_maybe_render() {
    164         wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
     164        wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
    165165        $section = new WP_Customize_Section( $this->manager, 'bar' );
    166166        $customize_render_section_count = did_action( 'customize_render_section' );
     
    187187     */
    188188    function test_print_templates_standard() {
    189         wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
     189        wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
    190190
    191191        $section = new WP_Customize_Section( $this->manager, 'baz' );
     
    202202     */
    203203    function test_print_templates_custom() {
    204         wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
     204        wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
    205205
    206206        $section = new Custom_Section_Test( $this->manager, 'baz' );
Note: See TracChangeset for help on using the changeset viewer.