Make WordPress Core


Ignore:
Timestamp:
10/16/2015 09:04:12 PM (9 years ago)
Author:
wonderboymusic
Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/option/networkOption.php

    r35025 r35225  
    1212class Tests_Option_NetworkOption extends WP_UnitTestCase {
    1313    function test_add_network_option_not_available_on_other_network() {
    14         $id = $this->factory->network->create();
     14        $id = self::$factory->network->create();
    1515        $option = rand_str();
    1616        $value = rand_str();
     
    2121
    2222    function test_add_network_option_available_on_same_network() {
    23         $id = $this->factory->network->create();
     23        $id = self::$factory->network->create();
    2424        $option = rand_str();
    2525        $value = rand_str();
     
    3030
    3131    function test_delete_network_option_on_only_one_network() {
    32         $id = $this->factory->network->create();
     32        $id = self::$factory->network->create();
    3333        $option = rand_str();
    3434        $value = rand_str();
Note: See TracChangeset for help on using the changeset viewer.