Changeset 35225 for trunk/tests/phpunit/tests/post/nav-menu.php

Timestamp:

10/16/2015 09:04:12 PM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:

• trunk/tests/phpunit/tests/post/nav-menu.php (modified) (6 diffs)

trunk/tests/phpunit/tests/post/nav-menu.php

@@ -17 +17 @@
 
     function test_wp_get_associated_nav_menu_items() {
-        $tag_id = $this->factory->tag->create();
-        $cat_id = $this->factory->category->create();
-        $post_id = $this->factory->post->create();
-        $post_2_id = $this->factory->post->create();
-        $page_id = $this->factory->post->create( array( 'post_type' => 'page' ) );
+        $tag_id = self::$factory->tag->create();
+        $cat_id = self::$factory->category->create();
+        $post_id = self::$factory->post->create();
+        $post_2_id = self::$factory->post->create();
+        $page_id = self::$factory->post->create( array( 'post_type' => 'page' ) );
 
         $tag_insert = wp_update_nav_menu_item( $this->menu_id, 0, array(
@@ -108 +108 @@
 
         // Update the orphan with an associated nav menu
-        wp_update_nav_menu_item( $this->menu_id, $custom_item_id, array( 
+        wp_update_nav_menu_item( $this->menu_id, $custom_item_id, array(
             'menu-item-title'     => 'WordPress.org',
             ) );
@@ -120 +120 @@
     public function test_wp_get_nav_menu_items_with_taxonomy_term() {
         register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true ) );
-        $t = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
-        $child_terms = $this->factory->term->create_many( 2, array( 'taxonomy' => 'wptests_tax', 'parent' => $t ) );
+        $t = self::$factory->term->create( array( 'taxonomy' => 'wptests_tax' ) );
+        $child_terms = self::$factory->term->create_many( 2, array( 'taxonomy' => 'wptests_tax', 'parent' => $t ) );
 
         $term_menu_item = wp_update_nav_menu_item( $this->menu_id, 0, array(
@@ -141 +141 @@
      */
     function test_orderby_name_by_default() {
-        // We are going to create a random number of menus (min 2, max 10) 
+        // We are going to create a random number of menus (min 2, max 10)
         $menus_no = rand( 2, 10 );
 
@@ -149 +149 @@
 
         // This is the expected array of menu names
-        $expected_nav_menus_names = wp_list_pluck( 
+        $expected_nav_menus_names = wp_list_pluck(
             get_terms( 'nav_menu',  array( 'hide_empty' => false, 'orderby' => 'name' ) ),
             'name'
@@ -156 +156 @@
         // And this is what we got when calling wp_get_nav_menus()
         $nav_menus_names = wp_list_pluck( wp_get_nav_menus(), 'name' );
-        
+
         $this->assertEquals( $nav_menus_names, $expected_nav_menus_names );
     }