Context Navigation

← Previous Change
Next Change →

slashes.php

Timestamp:

10/16/2015 09:04:12 PM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: one $factory to rule them all, and it shall be static.

Using more than one instance of WP_UnitTest_Factory causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use setUpBeforeClass, we were creating ad hoc instances. To avoid that, we were injecting one static instance via Dependency Injection in wpSetUpBeforeClass. All tests should really use the static instance, so we will remove the instance prop $factory.

Replace $this->factory with self::$factory over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.

#YOLOFriday

File:

: 1 edited

trunk/tests/phpunit/tests/user/slashes.php (modified) (3 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/user/slashes.php

-              r31065
+              r35225
         function setUp() {
                 parent::setUp();
                 $this->author_id = $this->factory->user->create( array( 'role' => 'administrator' ) );
+                $this->author_id = self::$factory->user->create( array( 'role' => 'administrator' ) );
                 $this->old_current_user = get_current_user_id();
                 wp_set_current_user( $this->author_id );
 …
          */
         function test_edit_user() {
                 $id = $this->factory->user->create();
+                $id = self::$factory->user->create();
                 $_POST = $_GET = $_REQUEST = array();
 …
          */
         function test_wp_update_user() {
                 $id = $this->factory->user->create();
+                $id = self::$factory->user->create();
                 $id = wp_update_user(array(
                         'ID' => $id,

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 35225 for trunk/tests/phpunit/tests/user/slashes.php

Legend:

trunk/tests/phpunit/tests/user/slashes.php

Download in other formats: