Changeset 35242 for trunk/tests/phpunit/includes/testcase.php

Timestamp:

10/17/2015 06:02:16 PM (9 years ago)

Author:

wonderboymusic

Message:

Unit Tests: after [35225], make factory a method/getter on WP_UnitTestCase and add magic methods for BC for every plugin that is extending WP_UnitTestCase and accessing the $factory instance prop.

Props nerrad, wonderboymusic.
See #30017, #33968.

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (3 diffs)

trunk/tests/phpunit/includes/testcase.php

@@ -15 +15 @@
     protected static $ignore_files;
 
-    /**
-     * @var WP_UnitTest_Factory
-     */
-    protected static $factory;
+    function __isset( $name ) {
+        return 'factory' === $name;
+    }
+
+    function __get( $name ) {
+        if ( 'factory' === $name ) {
+            return self::factory();
+        }
+    }
+
+    protected static function factory() {
+        static $factory = null;
+        if ( ! $factory ) {
+            $factory = new WP_UnitTest_Factory();
+        }
+        return $factory;
+    }
 
     public static function get_called_class() {
@@ -38 +51 @@
         parent::setUpBeforeClass();
 
-        if ( ! self::$factory ) {
-            self::$factory = new WP_UnitTest_Factory();
-        }
-
         $c = self::get_called_class();
         if ( ! method_exists( $c, 'wpSetUpBeforeClass' ) ) {
@@ -47 +56 @@
         }
 
-        call_user_func( array( $c, 'wpSetUpBeforeClass' ), self::$factory );
+        call_user_func( array( $c, 'wpSetUpBeforeClass' ), self::factory() );
 
         self::commit_transaction();