Changeset 35249

Timestamp:

10/17/2015 09:28:43 PM (11 years ago)

Author:

wonderboymusic

Message:

Unit Tests: better fixtures for Tests_Meta_Slashes and Tests_WP_Customize_Section.

See #30017, #33968.

Location:

trunk/tests/phpunit/tests

Files:

• customize/section.php (modified) (5 diffs)
• meta/slashes.php (modified) (4 diffs)

trunk/tests/phpunit/tests/customize/section.php

@@ -7 +7 @@
  */
 class Tests_WP_Customize_Section extends WP_UnitTestCase {
+        protected static $admin_id;
+        protected static $user_ids = array();
+
+        public static function wpSetUpBeforeClass( $factory ) {
+                self::$user_ids[] = self::$admin_id = $factory->user->create( array( 'role' => 'administrator' ) );
+        }
+
+        public static function wpTearDownAfterClass() {
+                foreach ( self::$user_ids as $id ) {
+                        self::delete_user( $id );
+                }
+        }
 
         /**
@@ -136 +148 @@
          */
         function test_check_capabilities() {
-                $user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
-                wp_set_current_user( $user_id );
+                wp_set_current_user( self::$admin_id );
 
                 $section = new WP_Customize_Section( $this->manager, 'foo' );
@@ -162 +173 @@
          */
         function test_maybe_render() {
-                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+                wp_set_current_user( self::$admin_id );
                 $section = new WP_Customize_Section( $this->manager, 'bar' );
                 $customize_render_section_count = did_action( 'customize_render_section' );
@@ -187 +198 @@
          */
         function test_print_templates_standard() {
-                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+                wp_set_current_user( self::$admin_id );
 
                 $section = new WP_Customize_Section( $this->manager, 'baz' );
@@ -202 +213 @@
          */
         function test_print_templates_custom() {
-                wp_set_current_user( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
+                wp_set_current_user( self::$admin_id );
 
                 $section = new Custom_Section_Test( $this->manager, 'baz' );

trunk/tests/phpunit/tests/meta/slashes.php

@@ -7 +7 @@
  */
 class Tests_Meta_Slashes extends WP_UnitTestCase {
+        protected static $editor_id;
+        protected static $post_id;
+        protected static $comment_id;
+
+        public static function wpSetUpBeforeClass( $factory ) {
+                self::$editor_id = $factory->user->create( array( 'role' => 'editor' ) );
+                self::$post_id = $factory->post->create();
+                self::$comment_id = $factory->comment->create( array( 'comment_post_ID' => self::$post_id ) );
+        }
+
+        public static function wpTearDownAfterClass() {
+                self::delete_user( self::$editor_id );
+                wp_delete_comment( self::$comment_id, true );
+                wp_delete_post( self::$post_id, true );
+        }
+
         function setUp() {
                 parent::setUp();
-                $this->author_id = self::factory()->user->create( array( 'role' => 'editor' ) );
-                $this->post_id = self::factory()->post->create();
-
-                wp_set_current_user( $this->author_id );
+
+                wp_set_current_user( self::$editor_id );
 
                 $this->slash_1 = 'String with 1 slash \\';
@@ -170 +184 @@
          */
         function test_add_comment_meta() {
-                $id = self::factory()->comment->create( array( 'comment_post_ID' => $this->post_id ) );
+                $id = self::$comment_id;
 
                 add_comment_meta( $id, 'slash_test_1', $this->slash_1 );
@@ -194 +208 @@
          */
         function test_update_comment_meta() {
-                $id = self::factory()->comment->create( array( 'comment_post_ID' => $this->post_id ) );
+                $id = self::$comment_id;
 
                 add_comment_meta( $id, 'slash_test_1', 'foo' );
@@ -268 +282 @@
                 $this->assertEquals( wp_unslash( $this->slash_6 ), get_user_meta( $id, 'slash_test_3', true ) );
         }
-
 }