Changeset 35299 for trunk/src/wp-admin/includes/class-wp-site-icon.php

Timestamp:

10/20/2015 06:22:41 PM (9 years ago)

Author:

obenland

Message:

Site Icon: Get site icon ID only when needed.

Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.

File:

• trunk/src/wp-admin/includes/class-wp-site-icon.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-icon.php

@@ -230 +230 @@
      */
     public function get_post_metadata( $value, $post_id, $meta_key, $single ) {
-        $site_icon_id = get_option( 'site_icon' );
-
-        if ( $post_id == $site_icon_id && '_wp_attachment_backup_sizes' == $meta_key && $single ) {
-            add_filter( 'intermediate_image_sizes', array( $this, 'intermediate_image_sizes' ) );
+        if ( $single && '_wp_attachment_backup_sizes' === $meta_key ) {
+            $site_icon_id = get_option( 'site_icon' );
+
+            if ( $post_id == $site_icon_id ) {
+                add_filter( 'intermediate_image_sizes', array( $this, 'intermediate_image_sizes' ) );
+            }
         }