Changeset 35299 for trunk/tests/phpunit/tests/image/site_icon.php

Timestamp:

10/20/2015 06:22:41 PM (9 years ago)

Author:

obenland

Message:

Site Icon: Get site icon ID only when needed.

Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.

File:

• trunk/tests/phpunit/tests/image/site_icon.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/site_icon.php

@@ -128 +128 @@
     }
 
+    /**
+     * @ticket 34368
+     */
+    function test_get_post_metadata() {
+        $attachment_id = $this->_insert_attachment();
+        update_option( 'site_icon', $attachment_id );
+
+        $this->wp_site_icon->get_post_metadata( '', $attachment_id, '_some_post_meta', true );
+        $this->assertFalse( has_filter( 'intermediate_image_sizes', array( $this->wp_site_icon, 'intermediate_image_sizes' ) ) );
+
+        $this->wp_site_icon->get_post_metadata( '', $attachment_id, '_wp_attachment_backup_sizes', true );
+        $this->assertSame( 10,  has_filter( 'intermediate_image_sizes', array( $this->wp_site_icon, 'intermediate_image_sizes' ) ) );
+
+        wp_delete_attachment( $attachment_id, true );
+    }
+
     function _custom_test_sizes( $sizes ) {
         $sizes[] = 321;