Changeset 35302 for trunk/src/wp-includes/class-wp-customize-setting.php

Timestamp:

10/20/2015 07:07:58 PM (9 years ago)

Author:

westonruter

Message:

Customizer: Implement indicators for invalid nav menu items.

The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.

Props kucrut, westonruter.
Fixes #33665.

File:

• trunk/src/wp-includes/class-wp-customize-setting.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -886 +886 @@
         'original_title'   => '',
         'nav_menu_term_id' => 0, // This will be supplied as the $menu_id arg for wp_update_nav_menu_item().
-        // @todo also expose invalid?
+        '_invalid'         => false,
     );
 
@@ -1143 +1143 @@
                 $this->value[ $key ] = intval( $this->value[ $key ] );
             }
+        }
+
+        if ( ! isset( $this->value['_invalid'] ) ) {
+            $this->value['_invalid'] = (
+                ( 'post_type' === $this->value['type'] && ! post_type_exists( $this->value['object'] ) )
+                ||
+                ( 'taxonomy' === $this->value['type'] && ! taxonomy_exists( $this->value['object'] ) )
+            );
         }
 
@@ -1247 +1255 @@
             false === $this_item
             ||
+            true === $this_item['_invalid']
+            ||
             (
                 $this->original_nav_menu_term_id === $menu->term_id
@@ -1418 +1428 @@
             'original_title'   => '',
             'nav_menu_term_id' => 0,
+            '_invalid'         => false,
         );
         $menu_item_value = array_merge( $default, $menu_item_value );
@@ -1449 +1460 @@
             $menu_item_value['status'] = 'publish';
         }
+
+        $menu_item_value['_invalid'] = (bool) $menu_item_value['_invalid'];
 
         /** This filter is documented in wp-includes/class-wp-customize-setting.php */