Changeset 35308

Timestamp:

10/20/2015 10:44:44 PM (11 years ago)

Author:

westonruter

Message:

Customizer: Prevent nav_menu_item settings from becoming dirty when their controls are set up.

Since wp_setup_nav_menu_item() returns the classes property as an array but the Customizer manages the value as a string, the setting needs to initially export the value as a string. This prevents the classes property type change from causing the setting to get marked as dirty even though nothing changed. This is a regression from [34788].

See #34111.

File:

• trunk/src/wp-includes/class-wp-customize-setting.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -1150 +1150 @@
                         if ( ! is_int( $this->value[ $key ] ) ) {
                                 $this->value[ $key ] = intval( $this->value[ $key ] );
+                        }
+                }
+                foreach ( array( 'classes', 'xfn' ) as $key ) {
+                        if ( is_array( $this->value[ $key ] ) ) {
+                                $this->value[ $key ] = implode( ' ', $this->value[ $key ] );
                         }
                 }