Changeset 35333

Timestamp:

10/21/2015 04:53:51 PM (9 years ago)

Author:

boonebgorges

Message:

Prevent non-public taxonomies from registering aquery var.

[34247] made the 'public' paramater of register_taxonomy() work by blocking
requests for non-public taxonomy archives during parse_request(). Blocking
taxonomy archive requests this late means that it's impossible to register an
independent query var that matches the slug of a non-public taxonomy. By
moving the block to register_taxonomy() - not allowing these taxonomies to
register their query vars in the first place - we free up the slug for other
use. In addition, we free up a bit of processing (no need to look for the query
var in parse_request() and better parallel the way non-public post types
work. See register_post_type().

Non-public taxonomy archives that are requested using ?taxonomy=tax_name are
still blocked during parse_request. It's only custom query vars -
?tax_name=term - that are affected by this change.

Props mboynes.
Fixes #21949.

Location:

trunk

Files:

• src/wp-includes/class-wp.php (modified) (1 diff)
• src/wp-includes/taxonomy-functions.php (modified) (1 diff)
• tests/phpunit/includes/utils.php (modified) (1 diff)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/class-wp.php

@@ -312 +312 @@
         if ( ! is_admin() ) {
             foreach ( get_taxonomies( array( 'public' => false ), 'objects' ) as $taxonomy => $t ) {
-                // Check first for taxonomy-specific query_var.
-                if ( $t->query_var && isset( $this->query_vars[ $t->query_var ] ) ) {
-                    unset( $this->query_vars[ $t->query_var ] );
-                }
-
-                // Next, check the 'taxonomy' query_var.
+                /*
+                 * Disallow when set to the 'taxonomy' query var.
+                 * Non-public taxonomies cannot register custom query vars. See register_taxonomy().
+                 */
                 if ( isset( $this->query_vars['taxonomy'] ) && $taxonomy === $this->query_vars['taxonomy'] ) {
                     unset( $this->query_vars['taxonomy'], $this->query_vars['term'] );

trunk/src/wp-includes/taxonomy-functions.php

@@ -385 +385 @@
     }
 
-    if ( false !== $args['query_var'] && ! empty( $wp ) ) {
+    if ( false !== $args['query_var'] && false !== $args['public'] && ! empty( $wp ) ) {
         if ( true === $args['query_var'] )
             $args['query_var'] = $taxonomy;

trunk/tests/phpunit/includes/utils.php

@@ -358 +358 @@
 
     foreach ( get_taxonomies( array() , 'objects' ) as $t ) {
-        if ( ! empty( $t->query_var ) )
+        if ( $t->public && ! empty( $t->query_var ) )
             $GLOBALS['wp']->add_query_var( $t->query_var );
     }

trunk/tests/phpunit/tests/taxonomy.php

@@ -467 +467 @@
      * @ticket 21949
      */
+    public function test_it_should_be_possible_to_register_a_query_var_that_matches_the_name_of_a_nonpublic_taxonomy() {
+        global $wp;
+
+        register_taxonomy( 'wptests_tax', 'post', array(
+            'public' => false,
+        ) );
+        $t = $this->factory->term->create_and_get( array(
+            'taxonomy' => 'wptests_tax',
+        ) );
+
+        $p = $this->factory->post->create();
+        wp_set_object_terms( $p, $t->slug, 'wptests_tax' );
+
+        add_filter( 'do_parse_request', array( $this, 'register_query_var' ) );
+        $this->go_to( '/?wptests_tax=foo' );
+        remove_filter( 'do_parse_request', array( $this, 'register_query_var' ) );
+
+        // Not a taxonomy...
+        $this->assertFalse( is_tax( 'wptests_tax' ) );
+
+        // ...but query var works.
+        $this->assertSame( 'foo', $wp->query_vars['wptests_tax'] );
+    }
+
+    public static function register_query_var( $r ) {
+        global $wp;
+
+        $wp->add_query_var( 'wptests_tax' );
+
+        return $r;
+    }
+
+    /**
+     * @ticket 21949
+     */
     public function test_nonpublic_taxonomy_should_not_be_queryable_using_taxonomy_and_term_vars() {
         register_taxonomy( 'wptests_tax', 'post', array(