Changeset 35337 for trunk/src/wp-admin/options-general.php

Timestamp:

10/21/2015 05:38:44 PM (10 years ago)

Author:

ocean90

Message:

Options: Hide the week starts on setting for installs that have the default setting already.

The default setting is the value of $wp_locale->start_of_week which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

File:

• trunk/src/wp-admin/options-general.php (modified) (2 diffs)

trunk/src/wp-admin/options-general.php

@@ -54 +54 @@
 
 <form method="post" action="options.php" novalidate="novalidate">
-<?php settings_fields('general'); ?>
+<?php
+settings_fields( 'general' );
+
+/**
+ * @global WP_Locale $wp_locale
+ */
+global $wp_locale;
+if ( get_option( 'start_of_week' ) != $wp_locale->start_of_week ) {
+    add_settings_field( 'start_of_week', __( 'Week Starts On' ), 'options_general_start_of_week', 'general', 'default', array( 'label_for' => 'start_of_week' ) );
+}
+?>
 
 <table class="form-table">
@@ -275 +285 @@
 </td>
 </tr>
-<tr>
-<th scope="row"><label for="start_of_week"><?php _e('Week Starts On') ?></label></th>
-<td><select name="start_of_week" id="start_of_week">
-<?php
-/**
- * @global WP_Locale $wp_locale
- */
-global $wp_locale;
-
-for ($day_index = 0; $day_index <= 6; $day_index++) :
-    $selected = (get_option('start_of_week') == $day_index) ? 'selected="selected"' : '';
-    echo "\n\t<option value='" . esc_attr($day_index) . "' $selected>" . $wp_locale->get_weekday($day_index) . '</option>';
-endfor;
-?>
-</select></td>
-</tr>
-<?php do_settings_fields('general', 'default'); ?>
+
+<?php do_settings_fields( 'general', 'default' ); ?>
 
 <?php