Changeset 35414

Timestamp:

10/28/2015 05:56:22 PM (9 years ago)

Author:

wonderboymusic

Message:

Dashboard: make tags used for headings more semantic.

Props Cheffheid, afercia.
Fixes #33558.

Location:

trunk/src/wp-admin

Files:

• css/common.css (modified) (3 diffs)
• css/dashboard.css (modified) (9 diffs)
• includes/dashboard.php (modified) (10 diffs)

trunk/src/wp-admin/css/common.css

@@ -565 +565 @@
 }
 
-.wrap > h2:first-child, /* Back-compat for old plugins */
-.wrap h1,
-.subtitle {
-    font-weight: normal;
-    margin: 0;
-}
-
-.wrap > h2:first-child, /* Back-compat for old plugins */
+.wrap > h2:first-child, /* Back-compat for pre-4.4 */
+.wrap [class$="icon32"] + h2, /* Back-compat for pre-4.4 */
+.postbox .inside h2, /* Back-compat for pre-4.4 */
 .wrap h1 {
     font-size: 23px;
     font-weight: 400;
+    margin: 0;
     padding: 9px 15px 4px 0;
     line-height: 29px;
@@ -581 +577 @@
 
 .subtitle {
+    margin: 0;
+    padding-left: 25px;
     color: #777;
     font-size: 14px;
-    padding-left: 25px;
+    font-weight: normal;
 }
 
@@ -2059 +2057 @@
 }
 
-.metabox-holder h3.hndle, /* Back-compat for pre-4.4 */
 .metabox-holder .stuffbox > h3, /* Back-compat for pre-4.4 */
 .metabox-holder .postbox > h3, /* Back-compat for pre-4.4 */
-.metabox-holder h2 {
+.metabox-holder h3.hndle, /* Back-compat for pre-4.4 */
+.metabox-holder h2.hndle {
     font-size: 14px;
     padding: 8px 12px;

trunk/src/wp-admin/css/dashboard.css

@@ -116 +116 @@
 }
 
-.welcome-panel h3 {
+.welcome-panel h2 {
     margin: 0;
     font-size: 21px;
@@ -123 +123 @@
 }
 
-.welcome-panel h4 {
+.welcome-panel h3 {
     margin: 1.33em 0 0;
     font-size: 16px;
@@ -361 +361 @@
 }
 
-#dashboard-widgets h4.mu-storage {
-    margin-bottom: 10px;
+#dashboard-widgets h3.mu-storage {
+    margin: 0 0 10px;
+    padding: 0;
+    font-size: 14px;
+    font-weight: normal;
 }
 
@@ -379 +382 @@
 }
 
-#dashboard_right_now .sub h4 {
+#dashboard_right_now .sub h3 {
     color: #555;
 }
@@ -538 +541 @@
 }
 
-#dashboard_quick_press .drafts h4 {
-    margin: 0 12px 8px;
-    font-weight: normal;
-}
-
 #dashboard_quick_press .drafts .view-all {
     float: right;
@@ -577 +575 @@
 }
 
+/* Dashboard common styles */
+
+#dashboard-widgets h4, /* Back-compat for pre-4.4 */
+#dashboard-widgets h3,
+#dashboard_quick_press .drafts h2 {
+    margin: 0 12px 8px;
+    padding: 0;
+    font-size: 14px;
+    font-weight: normal;
+    color: #23282d;
+}
+
+#dashboard-widgets .inside h4, /* Back-compat for pre-4.4 */
+#dashboard-widgets .inside h3 {
+    margin-left: 0;
+    margin-right: 0;
+}
+
 /* Dashboard activity widget */
-
-#dashboard-widgets #dashboard_activity h4 {
-    margin: 0 0 8px 12px;
-    font-weight: normal;
-}
-
-#dashboard-widgets #dashboard_activity h4.comment-meta {
-    margin: 0;
-}
-
-#dashboard_activity h4.comment-meta {
-    margin-bottom: 4px;
-}
 
 #dashboard_activity ul {
@@ -707 +710 @@
 #activity-widget #the-comment-list .dashboard-comment-wrap blockquote {
     margin: 1em 0;
-}
-
-#activity-widget #the-comment-list .comment-item h4 {
-    font-size: 13px;
-    color: #999;
 }
 
@@ -795 +793 @@
 }
 
-#dashboard-widgets h4 {
-    color: #23282d;
-    font-weight: normal;
-    font-size: 14px;
-    margin: 0 0 .2em;
-    padding: 0;
-}
-
 #dashboard_plugins h5 {
     font-size: 14px;
@@ -835 +825 @@
 }
 
-#latest-comments #the-comment-list .comment-item h4 {
+#latest-comments #the-comment-list .comment-meta {
     line-height: 1.5em;
-    margin-top: 0;
+    margin: 0;
     color: #666;
 }
 
-#latest-comments #the-comment-list .comment-item h4 cite {
+#latest-comments #the-comment-list .comment-meta cite {
     font-style: normal;
     font-weight: normal;

trunk/src/wp-admin/includes/dashboard.php

@@ -541 +541 @@
     echo '<div class="drafts">';
     if ( count( $drafts ) > 3 ) {
-        echo '<p class="view-all"><a href="' . esc_url( admin_url( 'edit.php?post_status=draft' ) ) . '">' . _x( 'View all', 'drafts' ) . "</a></p>\n";
+        echo '<p class="view-all"><a href="' . esc_url( admin_url( 'edit.php?post_status=draft' ) ) . '" aria-label="' . __( 'View all drafts' ) . '">' . _x( 'View all', 'drafts' ) . "</a></p>\n";
     }
-    echo '<h4 class="hide-if-no-js">' . __( 'Drafts' ) . "</h4>\n<ul>";
+    echo '<h2 class="hide-if-no-js">' . __( 'Drafts' ) . "</h2>\n<ul>";
 
     $drafts = array_slice( $drafts, 0, 3 );
@@ -649 +649 @@
 
             <div class="dashboard-comment-wrap has-row-actions">
-            <h4 class="comment-meta">
+            <p class="comment-meta">
                 <?php
                 if ( $comment_post_link ) {
@@ -668 +668 @@
                 }
                 ?>
-            </h4>
+            </p>
 
             <?php
@@ -686 +686 @@
             <div class="dashboard-comment-wrap has-row-actions">
             <?php /* translators: %1$s is type of comment, %2$s is link to the post */ ?>
-            <h4 class="comment-meta"><?php printf( _x( '%1$s on %2$s', 'dashboard' ), "<strong>$type</strong>", $comment_post_link ); ?></h4>
+            <p class="comment-meta"><?php printf( _x( '%1$s on %2$s', 'dashboard' ), "<strong>$type</strong>", $comment_post_link ); ?></p>
             <p class="comment-author"><?php comment_author_link( $comment ); ?></p>
 
@@ -776 +776 @@
         echo '<div id="' . $args['id'] . '" class="activity-block">';
 
-        echo '<h4>' . $args['title'] . '</h4>';
+        echo '<h3>' . $args['title'] . '</h3>';
 
         echo '<ul>';
@@ -855 +855 @@
     if ( $comments ) {
         echo '<div id="latest-comments" class="activity-block">';
-        echo '<h4>' . __( 'Comments' ) . '</h4>';
+        echo '<h3>' . __( 'Comments' ) . '</h3>';
 
         echo '<div id="the-comment-list" data-wp-lists="list:comment">';
@@ -1225 +1225 @@
 
     ?>
-    <h4 class="mu-storage"><?php _e( 'Storage Space' ); ?></h4>
+    <h3 class="mu-storage"><?php _e( 'Storage Space' ); ?></h3>
     <div class="mu-storage">
     <ul>
@@ -1379 +1379 @@
     ?>
     <div class="welcome-panel-content">
-    <h3><?php _e( 'Welcome to WordPress!' ); ?></h3>
+    <h2><?php _e( 'Welcome to WordPress!' ); ?></h2>
     <p class="about-description"><?php _e( 'We&#8217;ve assembled some links to get you started:' ); ?></p>
     <div class="welcome-panel-column-container">
     <div class="welcome-panel-column">
         <?php if ( current_user_can( 'customize' ) ): ?>
-            <h4><?php _e( 'Get Started' ); ?></h4>
+            <h3><?php _e( 'Get Started' ); ?></h3>
             <a class="button button-primary button-hero load-customize hide-if-no-customize" href="<?php echo wp_customize_url(); ?>"><?php _e( 'Customize Your Site' ); ?></a>
         <?php endif; ?>
@@ -1393 +1393 @@
     </div>
     <div class="welcome-panel-column">
-        <h4><?php _e( 'Next Steps' ); ?></h4>
+        <h3><?php _e( 'Next Steps' ); ?></h3>
         <ul>
         <?php if ( 'page' == get_option( 'show_on_front' ) && ! get_option( 'page_for_posts' ) ) : ?>
@@ -1410 +1410 @@
     </div>
     <div class="welcome-panel-column welcome-panel-last">
-        <h4><?php _e( 'More Actions' ); ?></h4>
+        <h3><?php _e( 'More Actions' ); ?></h3>
         <ul>
         <?php if ( current_theme_supports( 'widgets' ) || current_theme_supports( 'menus' ) ) : ?>