Changeset 35415

Timestamp:

10/28/2015 06:02:41 PM (9 years ago)

Author:

wonderboymusic

Message:

Mail: in wp_notify_postauthor() and wp_notify_moderator(), ensure that special chars aren't HTML-encoded in the email message body.

Props solarissmoke, leemon.
Fixes #12584.

File:

• trunk/src/wp-includes/pluggable.php (modified) (8 diffs)

trunk/src/wp-includes/pluggable.php

@@ -1458 +1458 @@
     // we want to reverse this for the plain text arena of emails.
     $blogname = wp_specialchars_decode(get_option('blogname'), ENT_QUOTES);
-
+    $comment_content = wp_specialchars_decode( $comment->comment_content );
+    
     switch ( $comment->comment_type ) {
         case 'trackback':
@@ -1465 +1466 @@
             $notify_message .= sprintf( __('Website: %1$s (IP: %2$s, %3$s)'), $comment->comment_author, $comment->comment_author_IP, $comment_author_domain ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment->comment_content ) . "\r\n\r\n";
+            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment_content ) . "\r\n\r\n";
             $notify_message .= __( 'You can see all trackbacks on this post here:' ) . "\r\n";
             /* translators: 1: blog name, 2: post title */
@@ -1475 +1476 @@
             $notify_message .= sprintf( __('Website: %1$s (IP: %2$s, %3$s)'), $comment->comment_author, $comment->comment_author_IP, $comment_author_domain ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment->comment_content ) . "\r\n\r\n";
+            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment_content ) . "\r\n\r\n";
             $notify_message .= __( 'You can see all pingbacks on this post here:' ) . "\r\n";
             /* translators: 1: blog name, 2: post title */
@@ -1486 +1487 @@
             $notify_message .= sprintf( __( 'Email: %s' ), $comment->comment_author_email ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= sprintf( __('Comment: %s' ), "\r\n" . $comment->comment_content ) . "\r\n\r\n";
+            $notify_message .= sprintf( __('Comment: %s' ), "\r\n" . $comment_content ) . "\r\n\r\n";
             $notify_message .= __( 'You can see all comments on this post here:' ) . "\r\n";
             /* translators: 1: blog name, 2: post title */
@@ -1609 +1610 @@
     // we want to reverse this for the plain text arena of emails.
     $blogname = wp_specialchars_decode(get_option('blogname'), ENT_QUOTES);
+    $comment_content = wp_specialchars_decode( $comment->comment_content );
 
     switch ( $comment->comment_type ) {
@@ -1617 +1619 @@
             $notify_message .= sprintf( __( 'Website: %1$s (IP: %2$s, %3$s)' ), $comment->comment_author, $comment->comment_author_IP, $comment_author_domain ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= __('Trackback excerpt: ') . "\r\n" . $comment->comment_content . "\r\n\r\n";
+            $notify_message .= __('Trackback excerpt: ') . "\r\n" . $comment_content . "\r\n\r\n";
             break;
         case 'pingback':
@@ -1625 +1627 @@
             $notify_message .= sprintf( __( 'Website: %1$s (IP: %2$s, %3$s)' ), $comment->comment_author, $comment->comment_author_IP, $comment_author_domain ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= __('Pingback excerpt: ') . "\r\n" . $comment->comment_content . "\r\n\r\n";
+            $notify_message .= __('Pingback excerpt: ') . "\r\n" . $comment_content . "\r\n\r\n";
             break;
         default: // Comments
@@ -1633 +1635 @@
             $notify_message .= sprintf( __( 'Email: %s' ), $comment->comment_author_email ) . "\r\n";
             $notify_message .= sprintf( __( 'URL: %s' ), $comment->comment_author_url ) . "\r\n";
-            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment->comment_content ) . "\r\n\r\n";
+            $notify_message .= sprintf( __( 'Comment: %s' ), "\r\n" . $comment_content ) . "\r\n\r\n";
             break;
     }