Changeset 35436 for trunk/tests/phpunit/tests/oembed/headers.php

Timestamp:

10/29/2015 10:50:13 PM (9 years ago)

Author:

pento

Message:

Embeds: Who put this REST API infrastructure in my WordPress?

Well, while it's here, we probably should make use of it. The oEmbed endpoint now uses the REST API infrastructure, instead of providing its own.

Props swissspidy.

Fixes #34207.

File:

• trunk/tests/phpunit/tests/oembed/headers.php (modified) (1 diff)

trunk/tests/phpunit/tests/oembed/headers.php

@@ -8 +8 @@
  */
 class Tests_oEmbed_HTTP_Headers extends WP_UnitTestCase {
-    function test_request_json_response_headers() {
+    function test_rest_pre_serve_request_headers() {
         if ( ! function_exists( 'xdebug_get_headers' ) ) {
             $this->markTestSkipped( 'xdebug is required for this test' );
         }
 
-        $post = self::factory()->post->create_and_get( array(
+        $post = $this->factory()->post->create_and_get( array(
             'post_title'  => 'Hello World',
         ) );
 
-        $request = array(
-            'url'      => get_permalink( $post->ID ),
-            'format'   => 'json',
-            'maxwidth' => 600,
-            'callback' => '',
-        );
+        $request = new WP_REST_Request( 'GET', '/oembed/1.0/embed' );
+        $request->set_param( 'url', get_permalink( $post->ID ) );
+        $request->set_param( 'format', 'xml' );
 
-        $legacy_controller = new WP_oEmbed_Controller();
-        $legacy_controller->dispatch( $request );
+        $server   = new WP_REST_Server();
+        $response = $server->dispatch( $request );
+        $output   = get_echo( '_oembed_rest_pre_serve_request', array( true, $response, $request, $server ) );
 
-        $headers = xdebug_get_headers();
-
-        $this->assertTrue( in_array( 'Content-Type: application/json; charset=' . get_option( 'blog_charset' ), $headers ) );
-        $this->assertTrue( in_array( 'X-Content-Type-Options: nosniff', $headers ) );
-
-        $request['callback'] = 'foobar';
-
-        $legacy_controller->dispatch( $request );
-
-        $headers = xdebug_get_headers();
-
-        $this->assertTrue( in_array( 'Content-Type: application/javascript; charset=' . get_option( 'blog_charset' ), $headers ) );
-        $this->assertTrue( in_array( 'X-Content-Type-Options: nosniff', $headers ) );
-    }
-
-    function test_request_xml_response_headers() {
-        if ( ! function_exists( 'xdebug_get_headers' ) ) {
-            $this->markTestSkipped( 'xdebug is required for this test' );
-        }
-
-        $post = self::factory()->post->create_and_get( array(
-            'post_title'  => 'Hello World',
-        ) );
-
-        $request = array(
-            'url'      => get_permalink( $post->ID ),
-            'format'   => 'xml',
-            'maxwidth' => 600,
-        );
-
-        $legacy_controller = new WP_oEmbed_Controller();
-        $legacy_controller->dispatch( $request );
+        $this->assertNotEmpty( $output );
 
         $headers = xdebug_get_headers();