Changeset 35443 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

10/30/2015 01:32:17 AM (9 years ago)

Author:

SergeyBiryukov

Message:

Don't use <a> in translatable strings in `wp-admin/includes/dashboard.php'.

Add translator commments.

Props ramiy.
Fixes #34501.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (1 diff)

trunk/src/wp-admin/includes/dashboard.php

@@ -1266 +1266 @@
     if ( $response ) {
         if ( $response['insecure'] ) {
-            $msg = sprintf( __( "It looks like you're using an insecure version of <a href='%s'>%s</a>. Using an outdated browser makes your computer unsafe. For the best WordPress experience, please update your browser." ), esc_attr( $response['update_url'] ), esc_html( $response['name'] ) );
+            /* translators: %s: browser name and link */
+            $msg = sprintf( __( "It looks like you're using an insecure version of %s. Using an outdated browser makes your computer unsafe. For the best WordPress experience, please update your browser." ),
+                sprintf( '<a href="%s">%s</a>', esc_url( $response['update_url'] ), esc_html( $response['name'] ) )
+            );
         } else {
-            $msg = sprintf( __( "It looks like you're using an old version of <a href='%s'>%s</a>. For the best WordPress experience, please update your browser." ), esc_attr( $response['update_url'] ), esc_html( $response['name'] ) );
+            /* translators: %s: browser name and link */
+            $msg = sprintf( __( "It looks like you're using an old version of %s. For the best WordPress experience, please update your browser." ),
+                sprintf( '<a href="%s">%s</a>', esc_url( $response['update_url'] ), esc_html( $response['name'] ) )
+            );
         }