Changeset 35478

Timestamp:

10/31/2015 08:38:07 PM (8 years ago)

Author:

wonderboymusic

Message:

WP oEmbed: Improve height attribute sanitization

Props afercia, swissspidy.
Fixes #34527.

File:

• trunk/src/wp-includes/js/wp-embed.js (modified) (1 diff)

trunk/src/wp-includes/js/wp-embed.js

@@ -32 +32 @@
             /* Resize the iframe on request. */
             if ( 'height' === data.message ) {
-                height = data.value;
+                height = parseInt( data.value, 10 );
                 if ( height > 1000 ) {
                     height = 1000;
-                } else if ( height < 200 ) {
+                } else if ( ~~height < 200 ) {
                     height = 200;
                 }
 
-                source.height = (height) + 'px';
+                source.height = height;
             }