Changeset 35515 for trunk/tests/phpunit/tests/term/meta.php

Timestamp:

11/04/2015 09:23:28 PM (10 years ago)

Author:

boonebgorges

Message:

Don't allow term meta to be added to shared taxonomy terms.

add_term_meta() and update_term_meta() identify terms by $term_id. In
cases where a term is shared between taxonomies, $term_id is insufficient to
distinguish where the metadata belongs.

When attempting to add/update termmeta on a shared term, a WP_Error object
is returned. This gives developers enough information to decide whether they'd
like to force the term to be split and retry the save, or show an error in the
UI, or whatever.

Props boonebgorges, mboynes, DH-Shredder, jorbin, aaroncampbell.
Fixes #34544.

File:

• trunk/tests/phpunit/tests/term/meta.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/meta.php

@@ -308 +308 @@
     }
 
+    /**
+     * @ticket 34544
+     */
+    public function test_add_term_meta_should_return_error_when_term_id_is_shared() {
+        global $wpdb;
+
+        update_option( 'finished_splitting_shared_terms', false );
+
+        register_taxonomy( 'wptests_tax', 'post' );
+        register_taxonomy( 'wptests_tax_2', 'post' );
+        register_taxonomy( 'wptests_tax_3', 'post' );
+
+        $t1 = wp_insert_term( 'Foo', 'wptests_tax' );
+        $t2 = wp_insert_term( 'Foo', 'wptests_tax_2' );
+        $t3 = wp_insert_term( 'Foo', 'wptests_tax_3' );
+
+        // Manually modify because shared terms shouldn't naturally occur.
+        $wpdb->update( $wpdb->term_taxonomy,
+            array( 'term_id' => $t1['term_id'] ),
+            array( 'term_taxonomy_id' => $t2['term_taxonomy_id'] ),
+            array( '%d' ),
+            array( '%d' )
+        );
+
+        $wpdb->update( $wpdb->term_taxonomy,
+            array( 'term_id' => $t1['term_id'] ),
+            array( 'term_taxonomy_id' => $t3['term_taxonomy_id'] ),
+            array( '%d' ),
+            array( '%d' )
+        );
+
+        $found = add_term_meta( $t1['term_id'], 'bar', 'baz' );
+        $this->assertWPError( $found );
+        $this->assertSame( 'ambiguous_term_id', $found->get_error_code() );
+    }
+
+    /**
+     * @ticket 34544
+     */
+    public function test_update_term_meta_should_return_error_when_term_id_is_shared() {
+        global $wpdb;
+
+        update_option( 'finished_splitting_shared_terms', false );
+
+        register_taxonomy( 'wptests_tax', 'post' );
+        $t1 = wp_insert_term( 'Foo', 'wptests_tax' );
+        add_term_meta( $t1, 'foo', 'bar' );
+
+        register_taxonomy( 'wptests_tax_2', 'post' );
+        register_taxonomy( 'wptests_tax_3', 'post' );
+
+        $t2 = wp_insert_term( 'Foo', 'wptests_tax_2' );
+        $t3 = wp_insert_term( 'Foo', 'wptests_tax_3' );
+
+        // Manually modify because shared terms shouldn't naturally occur.
+        $wpdb->update( $wpdb->term_taxonomy,
+            array( 'term_id' => $t1['term_id'] ),
+            array( 'term_taxonomy_id' => $t2['term_taxonomy_id'] ),
+            array( '%d' ),
+            array( '%d' )
+        );
+
+        $wpdb->update( $wpdb->term_taxonomy,
+            array( 'term_id' => $t1['term_id'] ),
+            array( 'term_taxonomy_id' => $t3['term_taxonomy_id'] ),
+            array( '%d' ),
+            array( '%d' )
+        );
+
+        $found = update_term_meta( $t1['term_id'], 'foo', 'baz' );
+        $this->assertWPError( $found );
+        $this->assertSame( 'ambiguous_term_id', $found->get_error_code() );
+    }
+
     public static function set_cache_results( $q ) {
         $q->set( 'cache_results', true );