Changeset 35561 for trunk/tests/phpunit/tests/media.php

Timestamp:

11/07/2015 02:09:56 AM (10 years ago)

Author:

azaozz

Message:

Responsive images: omit full size images from srcset attributes when the original file is an intermediate sized GIF so we don't accidentally add animation to an otherwise flat image. Update the tests to cover this case.

Props joemcgill, H-Shredder, SergeyBiryukov.
Fixes #34528.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -1013 +1013 @@
         );
 
-        $image_src = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $image_meta['file'];
+        $full_src  = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $image_meta['file'];
+        $large_src = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . $image_meta['sizes']['large']['file'];
+
         // Test with soft resized size array.
         $size_array = array(900, 450);
 
-        $this->assertFalse( wp_calculate_image_srcset( $image_src, $size_array, $image_meta ) );
+        // Full size GIFs should not return a srcset.
+        $this->assertFalse( wp_calculate_image_srcset( $full_src, $size_array, $image_meta ) );
+        // Intermediate sized GIFs should not include the full size in the srcset.
+        $this->assertFalse( strpos( wp_calculate_image_srcset( $large_src, $size_array, $image_meta ), $full_src ) );
     }
 }