Changeset 35615

Timestamp:

11/11/2015 08:59:56 PM (9 years ago)

Author:

ocean90

Message:

Comments: Dynamically update the document title text for all languages, not only English.

See [33821].
Fixes #33414.

Location:

trunk/src

Files:

• wp-admin/js/edit-comments.js (modified) (2 diffs)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/js/edit-comments.js

@@ -99 +99 @@
         var newTitle, regExMatch, titleCount, commentFrag;
 
-        titleRegEx = titleRegEx || new RegExp( 'Comments (\\([0-9' + thousandsSeparator + ']+\\))?' );
+        titleRegEx = titleRegEx || new RegExp( adminCommentsL10n.docTitleCommentsCount.replace( '%s', '\\([0-9' + thousandsSeparator + ']+\\)' ) + '?' );
         // count funcs operate on a $'d element
         titleDiv = titleDiv || $( '<div />' );
@@ -118 +118 @@
             regExMatch = titleRegEx.exec( document.title );
             if ( regExMatch ) {
-                newTitle = document.title.replace( regExMatch[0], 'Comments (' + titleDiv.text() + ') ' );
+                newTitle = document.title.replace( regExMatch[0], adminCommentsL10n.docTitleCommentsCount.replace( '%s', titleDiv.text() ) + ' ' );
             }
         } else {
             regExMatch = titleRegEx.exec( newTitle );
             if ( regExMatch ) {
-                newTitle = newTitle.replace( regExMatch[0], 'Comments' );
+                newTitle = newTitle.replace( regExMatch[0], adminCommentsL10n.docTitleComments );
             }
         }

trunk/src/wp-includes/script-loader.php

@@ -488 +488 @@
             'reply' => __( 'Reply' ),
             'warnQuickEdit' => __( "Are you sure you want to edit this comment?\nThe changes you made will be lost." ),
+            'docTitleComments' => __( 'Comments' ),
+            /* translators: %s: comments count */
+            'docTitleCommentsCount' => __( 'Comments (%s)' ),
         ) );