Changeset 35674

Timestamp:

11/18/2015 07:04:33 PM (9 years ago)

Author:

wonderboymusic

Message:

List Tables: because we can never eradicate the existence of globals, ensure that $comment is hoisted into the global space inside WP_Comments_List_Table::single_row().

Fixes #34654.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -475 +475 @@
 
     /**
-     * @global WP_Post $post
-     *
-     * @param object $comment
-     */
-    public function single_row( $comment ) {
-        global $post;
+     * @global WP_Post    $post
+     * @global WP_Comment $comment
+     *
+     * @param WP_Comment $item
+     */
+    public function single_row( $item ) {
+        global $post, $comment;
+
+        $comment = $item;
 
         $the_comment_class = wp_get_comment_status( $comment );
@@ -497 +500 @@
         echo "</tr>\n";
 
-        $post = null;
+        unset( $post, $comment );
     }