Changeset 35678 for trunk/tests/phpunit/tests/media.php

Timestamp:

11/18/2015 07:47:11 PM (10 years ago)

Author:

wonderboymusic

Message:

Media: when making images responsive, check if they already have a sizes attribute.

Adds unit test.

Props jaspermdegroot.
Fixes #34678.

File:

• trunk/tests/phpunit/tests/media.php (modified) (3 diffs)

trunk/tests/phpunit/tests/media.php

@@ -962 +962 @@
         $img_no_width_height = str_replace( ' height="' . $size_array[1] . '"', '', $img_no_width_height );
         $img_no_size_id = str_replace( 'wp-image-', 'id-', $img );
+        $img_with_sizes_attr = str_replace( '<img ', '<img sizes="99vw" ', $img );
 
         // Manually add srcset and sizes to the markup from get_image_tag();
@@ -967 +968 @@
         $respimg_no_size_in_class = preg_replace( '|<img ([^>]+) />|', '<img $1 ' . $srcset . ' ' . $sizes . ' />', $img_no_size_in_class );
         $respimg_no_width_height = preg_replace( '|<img ([^>]+) />|', '<img $1 ' . $srcset . ' ' . $sizes . ' />', $img_no_width_height );
+        $respimg_with_sizes_attr = preg_replace('|<img ([^>]+) />|', '<img $1 ' . $srcset . ' />', $img_with_sizes_attr );
 
         $content = '
@@ -979 +981 @@
 
             <p>Image, no attachment ID class. Should NOT have srcset and sizes.</p>
-            %4$s';
-
-        $content_unfiltered = sprintf( $content, $img, $img_no_size_in_class, $img_no_width_height, $img_no_size_id );
-        $content_filtered = sprintf( $content, $respimg, $respimg_no_size_in_class, $respimg_no_width_height, $img_no_size_id );
+            %4$s
+
+            <p>Image, with sizes attribute. Should NOT have two sizes attributes.</p>
+            %5$s';
+
+        $content_unfiltered = sprintf( $content, $img, $img_no_size_in_class, $img_no_width_height, $img_no_size_id, $img_with_sizes_attr );
+        $content_filtered = sprintf( $content, $respimg, $respimg_no_size_in_class, $respimg_no_width_height, $img_no_size_id, $respimg_with_sizes_attr );
 
         $this->assertSame( $content_filtered, wp_make_content_images_responsive( $content_unfiltered ) );