Changeset 35679 for trunk/tests/phpunit/tests/query/conditionals.php

Timestamp:

11/18/2015 07:58:01 PM (10 years ago)

Author:

wonderboymusic

Message:

Rewrite: alleviate conflicts between image attachment pages and posts when permalink structure is /%postname%/.

Adds unit test.

Props SergeyBiryukov.
Fixes #24612.

File:

• trunk/tests/phpunit/tests/query/conditionals.php (modified) (1 diff)

trunk/tests/phpunit/tests/query/conditionals.php

@@ -761 +761 @@
     }
 
+    /**
+     * @ticket 24612
+     */
+    public function test_is_single_with_slug_that_clashes_with_attachment() {
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $attachment_id = $this->factory->post->create( array(
+            'post_type'  => 'attachment',
+        ) );
+
+        $post_id = $this->factory->post->create( array(
+            'post_title' => get_post( $attachment_id )->post_title
+        ) );
+
+        $this->go_to( get_permalink( $post_id ) );
+
+        $q = $GLOBALS['wp_query'];
+
+        $this->assertTrue( $q->is_single() );
+        $this->assertTrue( $q->is_single( $post_id ) );
+        $this->assertFalse( $q->is_attachment() );
+        $this->assertFalse( $q->is_404() );
+
+        $this->set_permalink_structure();
+    }
+
     function test_is_page() {
         $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );