Changeset 35680

Timestamp:

11/18/2015 07:58:21 PM (9 years ago)

Author:

boonebgorges

Message:

Allow filtering by non-public taxonomies on edit.php.

[35333] enforces protection for taxonomies by preventing non-public taxonomies
from registering query_vars in register_taxonomy(). This broke the use of
taxonomy query_vars on edit.php, breaking backward compatibility and
creating inconsistency with the treatment introduced in [34247], which allowed
taxonomy=foo filtering on the Dashboard, even when foo is non-public. In
this changeset, we make the same Dashboard exception for the query_var.

Fixes #21949.

File:

• trunk/src/wp-includes/taxonomy-functions.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy-functions.php

@@ -385 +385 @@
     }
 
-    if ( false !== $args['query_var'] && false !== $args['public'] && ! empty( $wp ) ) {
+    // Non-public taxonomies should not register query vars, except in the admin.
+    if ( false !== $args['query_var'] && ( is_admin() || false !== $args['public'] ) && ! empty( $wp ) ) {
         if ( true === $args['query_var'] )
             $args['query_var'] = $taxonomy;