Changeset 35688

Timestamp:

11/18/2015 08:48:24 PM (9 years ago)

Author:

jorbin

Message:

Revert [34291] bringing back my-hacks

Keeping myhacks support is a small price to pay for not breaking people's sites. Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.

https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.

Fixes #33741.

Location:

trunk/src

Files:

• wp-admin/includes/file.php (modified) (1 diff)
• wp-admin/includes/schema.php (modified) (1 diff)
• wp-includes/load.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -40 +40 @@
     'audio.php' => __('Audio Attachment Template'),
     'application.php' => __('Application Attachment Template'),
+    'my-hacks.php' => __( 'my-hacks.php (legacy hacks support)' ),
     '.htaccess' => __( '.htaccess (for rewrite rules )' ),
     // Deprecated files

trunk/src/wp-admin/includes/schema.php

@@ -421 +421 @@
     'moderation_notify' => 1,
     'permalink_structure' => '',
+    'hack_file' => 0,
     'blog_charset' => 'UTF-8',
     'moderation_keys' => '',

trunk/src/wp-includes/load.php

@@ -553 +553 @@
     $plugins = array();
     $active_plugins = (array) get_option( 'active_plugins', array() );
+
+    // Check for hacks file if the option is enabled
+    if ( get_option( 'hack_file' ) && file_exists( ABSPATH . 'my-hacks.php' ) ) {
+        _deprecated_file( 'my-hacks.php', '1.5' );
+        array_unshift( $plugins, ABSPATH . 'my-hacks.php' );
+    }
+
     if ( empty( $active_plugins ) || wp_installing() )
         return $plugins;