Changeset 35691

Timestamp:

11/18/2015 09:33:03 PM (9 years ago)

Author:

boonebgorges

Message:

Eliminate a db query when building the admin menu for non-privileged users.

Users who cannot edit_posts do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.

Props bordoni, johnbillion.
Fixes #19372.

File:

• trunk/src/wp-admin/menu.php (modified) (1 diff)

trunk/src/wp-admin/menu.php

@@ -68 +68 @@
 // $menu[20] = Pages
 
-$awaiting_mod = wp_count_comments();
-$awaiting_mod = $awaiting_mod->moderated;
-$menu[25] = array( sprintf( __('Comments %s'), "<span class='awaiting-mod count-$awaiting_mod'><span class='pending-count'>" . number_format_i18n($awaiting_mod) . "</span></span>" ), 'edit_posts', 'edit-comments.php', '', 'menu-top menu-icon-comments', 'menu-comments', 'dashicons-admin-comments' );
-unset($awaiting_mod);
+// Avoid the comment count query for users who cannot edit_posts.
+if ( current_user_can( 'edit_posts' ) ) {
+    $awaiting_mod = wp_count_comments();
+    $awaiting_mod = $awaiting_mod->moderated;
+    $menu[25] = array(
+        sprintf( __( 'Comments %s' ), '<span class="awaiting-mod count-' . absint( $awaiting_mod ) . '"><span class="pending-count">' . number_format_i18n( $awaiting_mod ) . '</span></span>' ),
+        'edit_posts',
+        'edit-comments.php',
+        '',
+        'menu-top menu-icon-comments',
+        'menu-comments',
+        'dashicons-admin-comments',
+    );
+    unset( $awaiting_mod );
+}
 
 $submenu[ 'edit-comments.php' ][0] = array( __('All Comments'), 'edit_posts', 'edit-comments.php' );