Changeset 35724 for trunk/tests/phpunit/tests/customize/widgets.php

Timestamp:

11/21/2015 02:51:57 AM (9 years ago)

Author:

westonruter

Message:

Customize: Ensure that a setting (especially a multidimensional one) can still be previewed when the post value to preview is set after preview() is invoked.

• Introduce customize_post_value_set_{$setting_id} and customize_post_value_set actions which are done when WP_Customize_Manager::set_post_value() is called.
• Clear the preview_applied flag for aggregated multidimensional settings when a post value is set. This ensures the new value is used instead of a previously-cached previewed value.
• Move $is_preview property from subclasses to WP_Customize_Setting parent class.
• Deferred preview: Ensure that when preview() short-circuits due to not being applicable that it will be called again later when the post value is set.
• Populate post value for updated-widget with the (unsanitized) JS-value in WP_Customize_Widgets::call_widget_update() so that value will be properly sanitized when accessed in WP_Customize_Manager::post_value().

Includes unit tests with assertions to check the reported issues and validate the fixes.

Fixes defect introduced in [35007].
See #32103.
Fixes #34738.

File:

• trunk/tests/phpunit/tests/customize/widgets.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/widgets.php

@@ -292 +292 @@
         $this->assertFalse( $this->manager->get_panel( 'widgets' )->active() );
     }
+
+    /**
+     * @ticket 34738
+     * @see WP_Customize_Widgets::call_widget_update()
+     */
+    function test_call_widget_update() {
+
+        $widget_number = 2;
+        $widget_id = "search-{$widget_number}";
+        $setting_id = "widget_search[{$widget_number}]";
+        $instance = array(
+            'title' => 'Buscar',
+        );
+
+        $_POST = wp_slash( array(
+            'action' => 'update-widget',
+            'wp_customize' => 'on',
+            'nonce' => wp_create_nonce( 'update-widget' ),
+            'theme' => $this->manager->get_stylesheet(),
+            'customized' => '{}',
+            'widget-search' => array(
+                2 => $instance,
+            ),
+            'widget-id' => $widget_id,
+            'id_base' => 'search',
+            'widget-width' => '250',
+            'widget-height' => '200',
+            'widget_number' => strval( $widget_number ),
+            'multi_number' => '',
+            'add_new' => '',
+        ) );
+
+        $this->do_customize_boot_actions();
+
+        $this->assertArrayNotHasKey( $setting_id, $this->manager->unsanitized_post_values() );
+        $result = $this->manager->widgets->call_widget_update( $widget_id );
+
+        $this->assertInternalType( 'array', $result );
+        $this->assertArrayHasKey( 'instance', $result );
+        $this->assertArrayHasKey( 'form', $result );
+        $this->assertEquals( $instance, $result['instance'] );
+        $this->assertContains( sprintf( 'value="%s"', esc_attr( $instance['title'] ) ), $result['form'] );
+
+        $post_values = $this->manager->unsanitized_post_values();
+        $this->assertArrayHasKey( $setting_id, $post_values );
+        $post_value = $post_values[ $setting_id ];
+        $this->assertInternalType( 'array', $post_value );
+        $this->assertArrayHasKey( 'title', $post_value );
+        $this->assertArrayHasKey( 'encoded_serialized_instance', $post_value );
+        $this->assertArrayHasKey( 'instance_hash_key', $post_value );
+        $this->assertArrayHasKey( 'is_widget_customizer_js_value', $post_value );
+        $this->assertEquals( $post_value, $this->manager->widgets->sanitize_widget_js_instance( $instance ) );
+    }
 }