Changeset 35753 for trunk/src/wp-includes/media.php

Timestamp:

12/01/2015 08:49:13 PM (11 years ago)

Author:

wonderboymusic

Message:

Media: don't use get_media_embedded_in_content() in wp_make_content_images_responsive().

Adds unit test.

Props azaozz.
Fixes #34807.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -1207 +1207 @@
  */
 function wp_make_content_images_responsive( $content ) {
-        $images = get_media_embedded_in_content( $content, 'img' );
+        if ( ! preg_match_all( '/<img [^>]+>/', $content, $matches ) ) {
+                return $content;
+        }
 
         $selected_images = $attachment_ids = array();
 
-        foreach( $images as $image ) {
+        foreach( $matches[0] as $image ) {
                 if ( false === strpos( $image, ' srcset=' ) && preg_match( '/wp-image-([0-9]+)/i', $image, $class_id ) &&
                         ( $attachment_id = absint( $class_id[1] ) ) ) {
@@ -3507 +3509 @@
          *
          * @since 4.2.0
-         * @since 4.4.0 Added 'img' to the allowed types.
          *
          * @param array $allowed_media_types An array of allowed media types. Default media types are
-         *                                   'audio', 'video', 'object', 'embed', 'iframe', and 'img'.
-         */
-        $allowed_media_types = apply_filters( 'media_embedded_in_content_allowed_types', array( 'audio', 'video', 'object', 'embed', 'iframe', 'img' ) );
+         *                                   'audio', 'video', 'object', 'embed', and 'iframe'.
+         */
+        $allowed_media_types = apply_filters( 'media_embedded_in_content_allowed_types', array( 'audio', 'video', 'object', 'embed', 'iframe' ) );
 
         if ( ! empty( $types ) ) {