Changeset 35765

Timestamp:

12/04/2015 04:12:51 PM (9 years ago)

Author:

DrewAPicture

Message:

About page: Fix some minor string errors and simplify URL-building for the plugin install link for capable users.

Props ocean90, DrewAPicture
See #34663.

File:

• trunk/src/wp-admin/about.php (modified) (4 diffs)

trunk/src/wp-admin/about.php

@@ -110 +110 @@
                         <p><?php
                             if ( current_user_can( 'install_plugins' ) ) {
-                                $plugin_link = '<a href="' . esc_url( network_admin_url( 'plugin-install.php?tab=plugin-information&plugin=rest-api' .
-                                        '&TB_iframe=true&width=600&height=550' ) ) . '" class="thickbox">WordPress REST API</a>';
+                                $url_args = array(
+                                    'tab'       => 'plugin-information',
+                                    'plugin'    => 'rest-api',
+                                    'TB_iframe' => true,
+                                    'width'     => 600,
+                                    'height'    => 550
+                                );
+
+                                $plugin_link = '<a href="' . esc_url( add_query_arg( $url_args, network_admin_url( 'plugin-install.php' ) ) ) . '" class="thickbox">WordPress REST API</a>';
                             } else {
                                 $plugin_link = '<a href="https://wordpress.org/plugins/rest-api">WordPress REST API</a>';
@@ -117 +124 @@
 
                             /* translators: WordPress REST API plugin link */
-                            printf( ( 'Infrastructure is the first part of a multi-stage rollout for the REST API, which also targets inclusion of core endpoints in an upcoming release. To get a sneak peek of the core endpoints, and for more on extending the REST API, check out the official %s plugin.' ),
-                                $plugin_link
-                            );
+                            printf( ( 'Infrastructure is the first part of a multi-stage rollout for the REST API, which also targets inclusion of core endpoints in an upcoming release. To get a sneak peek of the core endpoints, and for more on extending the REST API, check out the official %s plugin.' ), $plugin_link );
                         ?></p>
                     </div>
@@ -130 +135 @@
                     <p><?php
                         /* translators: 1: add_term_meta() docs link, 2: get_term_meta() docs link, 3: update_term_meta() docs link */
-                        printf( ( 'Terms now now support metadata, just like posts. See %1$s, %2$s, and %3$s for more information.' ),
+                        printf( ( 'Terms now support metadata, just like posts. See %1$s, %2$s, and %3$s for more information.' ),
                             '<a href="https://developer.wordpress.org/reference/functions/add_term_meta"><code>add_term_meta()</code></a>',
                             '<a href="https://developer.wordpress.org/reference/functions/get_term_meta"><code>get_term_meta()</code></a>',
@@ -141 +146 @@
                     <p><?php
                         /* translators: WP_Comment_Query class name */
-                        printf( ( 'Comment queries now have improved cache handling and performance. New arguments in %s making crafting robust comment queries simpler.' ), '<code>WP_Comment_Query</code>' );
+                        printf( ( 'Comment queries now have cache handling to improve performance. New arguments in %s make crafting robust comment queries simpler.' ), '<code>WP_Comment_Query</code>' );
                     ?></p>
                 </div>