Changeset 35777

Timestamp:

12/06/2015 05:06:53 PM (9 years ago)

Author:

dd32

Message:

Upgrader: FTP: Cleanup temporary files during FTP download failures.
Props ruud@joyo
Fixes #34772

File:

• trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -117 +117 @@
         $temp = fopen($tempfile, 'w+');
 
-        if ( ! $temp )
-            return false;
-
-        if ( ! @ftp_fget($this->link, $temp, $file, FTP_BINARY ) )
-            return false;
-
+        if ( ! $temp ) {
+            unlink( $tempfile );
+            return false;
+        }
+        
+        if ( ! @ftp_fget( $this->link, $temp, $file, FTP_BINARY ) ) {
+            fclose( $temp );
+            unlink( $tempfile );
+            return false;
+        }
+        
         fseek( $temp, 0 ); // Skip back to the start of the file being written to
         $contents = '';