Changeset 35790 for trunk/src/wp-admin/users.php

Timestamp:

12/06/2015 08:56:11 PM (10 years ago)

Author:

boonebgorges

Message:

Show user_login in Dashboard user dropdowns.

User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new display_name_with_login value for the show parameter of
wp_dropdown_users() enables this functionality. The default value of show
has not been changed, for backward compatibility, but all instances of
wp_dropdown_users() in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when include_selected is true.

Props krogsgard, boonebgorges.
Fixes #31251.

File:

• trunk/src/wp-admin/users.php (modified) (1 diff)

trunk/src/wp-admin/users.php

@@ -271 +271 @@
             <li><input type="radio" id="delete_option1" name="delete_option" value="reassign" />
             <?php echo '<label for="delete_option1">' . __( 'Attribute all content to:' ) . '</label> ';
-            wp_dropdown_users( array( 'name' => 'reassign_user', 'exclude' => array_diff( $userids, array($current_user->ID) ) ) ); ?></li>
+            wp_dropdown_users( array(
+                'name' => 'reassign_user',
+                'exclude' => array_diff( $userids, array( $current_user->ID ) ),
+                'show' => 'display_name_with_login',
+            ) ); ?></li>
         </ul></fieldset>
     <?php endif;