Changeset 35800

Timestamp:

12/06/2015 09:57:59 PM (9 years ago)

Author:

ericlewis

Message:

Posts: Don't modify post_name if it wasn't supplied to wp_insert_post().

Previously when updating a post using wp_insert_post(), post_name was
regenerated based on post_title every time if post_name was not passed in
explicitly. This irons out the expectation that properties not passed into the
function should not be modified.

Props jason_the_adams.
Fixes #34865.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -2873 +2873 @@
  *                                         Default is the value of 'default_ping_status' option.
  *     @type string $post_password         The password to access the post. Default empty.
- *     @type string $post_name             The post name. Default is the sanitized post title.
+ *     @type string $post_name             The post name. Default is the sanitized post title
+ *                                         when creating a new post.
  *     @type string $to_ping               Space or carriage return-separated list of URLs to ping.
  *                                         Default empty.
@@ -2954 +2955 @@
     if ( isset( $postarr['post_name'] ) ) {
         $post_name = $postarr['post_name'];
+    } elseif ( $update ) {
+        // For an update, don't modify the post_name if it wasn't supplied as an argument.
+        $post_name = $post_before->post_name;
     }
 

trunk/tests/phpunit/tests/post.php

@@ -1190 +1190 @@
 
     /**
+     * If a post is updated without providing a post_name param,
+     * a new slug should not be generated.
+     *
+     * @ticket 34865
+     */
+    function test_post_updates_without_slug_provided() {
+        $post_id = self::factory()->post->create( array(
+            'post_title'   => 'Stuff',
+            'post_status'  => 'publish'
+        ) );
+
+        $data = array(
+            'ID'         => $post_id,
+            'post_title' => 'Stuff and Things'
+        );
+
+        wp_insert_post( $data );
+
+        $updated_post = get_post( $post_id );
+        // Ensure changing the post_title didn't modify the post_name.
+        $this->assertEquals('stuff', $updated_post->post_name);
+    }
+
+    /**
      * @ticket 32585
      */