Changeset 35853

Timestamp:

12/10/2015 03:16:51 PM (9 years ago)

Author:

rachelbaker

Message:

Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.

In wp_update_comment() only check if the given comment_post_ID is valid if it isn’t 0. This allows comments that were created programmatically via wp_insert_comment() without the (optional) comment_post_ID parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954

Location:

trunk

Files:

• src/wp-includes/comment.php (modified) (1 diff)
• tests/phpunit/tests/comment.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -1905 +1905 @@
 
     // Make sure that the comment post ID is valid (if specified).
-    if ( isset( $commentarr['comment_post_ID'] ) && ! get_post( $commentarr['comment_post_ID'] ) ) {
+    if ( ! empty( $commentarr['comment_post_ID'] ) && ! get_post( $commentarr['comment_post_ID'] ) ) {
         return 0;
     }

trunk/tests/phpunit/tests/comment.php

@@ -71 +71 @@
     }
 
+    /**
+     * @ticket 34954
+     */
+    function test_wp_update_comment_with_no_post_id() {
+        $comment_id = self::factory()->comment->create( array( 'comment_post_ID' => 0 ) );
+
+        $updated_comment_text = 'I should be able to update a comment with a Post ID of zero';
+
+        $update = wp_update_comment( array( 'comment_ID' => $comment_id, 'comment_content' => $updated_comment_text, 'comment_post_ID' => 0 ) );
+        $this->assertSame( 1, $update );
+
+        $comment = get_comment( $comment_id );
+        $this->assertEquals( $updated_comment_text, $comment->comment_content );
+    }
+
     public function test_get_approved_comments() {
         $ca1 = self::factory()->comment->create( array(