WordPress.org

Make WordPress Core

Changeset 35854


Ignore:
Timestamp:
12/10/2015 05:20:18 PM (5 years ago)
Author:
afercia
Message:

Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.

Fixes #34763.

Location:
trunk/src/wp-admin
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-upgrader-skins.php

    r35219 r35854  
    225225        $this->plugin = $this->upgrader->plugin_info();
    226226        if ( !empty($this->plugin) && !is_wp_error($this->result) && $this->plugin_active ){
    227             echo '<iframe style="border:0;overflow:hidden" width="100%" height="170px" src="' . wp_nonce_url('update.php?action=activate-plugin&networkwide=' . $this->plugin_network_active . '&plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin) .'"></iframe>';
     227            // Currently used only when JS is off for a single plugin update?
     228            echo '<iframe title="' . esc_attr( 'Update progress' ) . '" style="border:0;overflow:hidden" width="100%" height="170" src="' . wp_nonce_url( 'update.php?action=activate-plugin&networkwide=' . $this->plugin_network_active . '&plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin ) . '"></iframe>';
    228229        }
    229230
  • trunk/src/wp-admin/update-core.php

    r35811 r35854  
    645645    echo '<div class="wrap">';
    646646    echo '<h1>' . __( 'Update Plugins' ) . '</h1>';
    647     echo '<iframe src="', $url, '" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>';
     647    echo '<iframe src="', $url, '" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0" title="' . esc_attr( 'Update progress' ) . '"></iframe>';
    648648    echo '</div>';
    649649    include(ABSPATH . 'wp-admin/admin-footer.php');
     
    674674    <div class="wrap">
    675675        <h1><?php _e( 'Update Themes' ); ?></h1>
    676         <iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>
     676        <iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0" title="<?php esc_attr_e( 'Update progress' ); ?>"></iframe>
    677677    </div>
    678678    <?php
Note: See TracChangeset for help on using the changeset viewer.