Make WordPress Core


Ignore:
Timestamp:
12/11/2015 04:31:06 PM (9 years ago)
Author:
afercia
Message:

Accessibility: on the Updates screen, remove a redundant title attribute.

Removes the title attribute from the Plugin details link and adds the Plugin name hidden with screen-reader-text within the link text.

Props Cheffheid.
Fixes #35001.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/update-core.php

    r35855 r35866  
    304304
    305305        $details_url = self_admin_url('plugin-install.php?tab=plugin-information&plugin=' . $plugin_data->update->slug . '&section=changelog&TB_iframe=true&width=640&height=662');
    306         $details_text = sprintf(__('View version %1$s details.'), $plugin_data->update->new_version);
    307         $details = sprintf('<a href="%1$s" class="thickbox" title="%2$s">%3$s</a>', esc_url($details_url), esc_attr($plugin_data->Name), $details_text);
     306        $details_name = sprintf( '<span class="screen-reader-text">%1$s</span>', esc_attr( $plugin_data->Name ) );
     307        /* translators: 1: Plugin name 2: Plugin version */
     308        $details_text = sprintf( __( 'View %1$s version %2$s details.' ), $details_name, $plugin_data->update->new_version );
     309        $details = sprintf( '<a href="%1$s" class="thickbox">%2$s</a>', esc_url( $details_url ), $details_text );
    308310
    309311        echo "
Note: See TracChangeset for help on using the changeset viewer.