Changeset 35932

Timestamp:

12/14/2015 07:39:31 PM (11 years ago)

Author:

boonebgorges

Message:

Don't use array_merge() when building comment children arrays.

array_merge() is much slower than building the combined array using a
foreach loop. The performance difference was causing a speed regression with
the get_children() functionality introduced in 4.4.

Merges [35931] to the 4.4 branch.

Props rogerhub.
Fixes #35025.

Location:

branches/4.4

Files:

• . (modified) (1 prop)
• src/wp-includes/comment-template.php (modified) (1 diff)

branches/4.4/src/wp-includes/comment-template.php

@@ -1331 +1331 @@
         $comments_flat = array();
         foreach ( $_comments as $_comment ) {
-                $comments_flat = array_merge( $comments_flat, array( $_comment ), $_comment->get_children( array(
+                $comments_flat[]  = $_comment;
+                $comment_children = $_comment->get_children( array(
                         'format' => 'flat',
                         'status' => $comment_args['status'],
                         'orderby' => $comment_args['orderby']
-                ) ) );
+                ) );
+
+                foreach ( $comment_children as $comment_child ) {
+                        $comments_flat[] = $comment_child;
+                }
         }