Changeset 35988

Timestamp:

12/17/2015 05:11:07 PM (9 years ago)

Author:

boonebgorges

Message:

Better focus in tag cloud tests.

We should avoid testing complete markup strings, unless we are specifically
testing for the format of the markup.

Fixes #35138.

File:

• trunk/tests/phpunit/tests/term/wpGenerateTagCloud.php (modified) (5 diffs)

trunk/tests/phpunit/tests/term/wpGenerateTagCloud.php

@@ -79 +79 @@
             'hide_empty' => false,
         ) );
-        $expected = "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$term->slug}' class='tag-link-0 tag-link-position-1' title='0 topics' style='font-size: 8pt;'>{$term->name}</a>";
-        $this->assertEquals( $expected, wp_generate_tag_cloud( $tags, array(
-            'hide_empty' => false,
-        ) ) );
+
+        $found = wp_generate_tag_cloud( $tags, array(
+            'hide_empty' => false,
+        ) );
+
+        $this->assertContains( '>' . $tags[0]->name . '<', $found );
     }
 
@@ -95 +97 @@
         ) );
 
-        $expected = "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$term->slug}' class='tag-link-0 tag-link-position-1' title='0 topics' style='font-size: 8pt;'>{$term->name}</a>";
-        $this->assertEquals( $expected, wp_generate_tag_cloud( $tags, array(
-            'hide_empty' => false,
-        ) ) );
+        $found = wp_generate_tag_cloud( $tags, array(
+            'hide_empty' => false,
+            'format' => 'array',
+        ) );
+
+        $this->assertInternalType( 'array', $found );
+        $this->assertContains( '>' . $tags[0]->name . '<', $found[0] );
     }
 
@@ -110 +115 @@
         ) );
 
-        $expected = "<ul class='wp-tag-cloud'>\n\t<li><a href='http://" . WP_TESTS_DOMAIN . "/?tag={$term->slug}' class='tag-link-0 tag-link-position-1' title='0 topics' style='font-size: 8pt;'>{$term->name}</a></li>\n</ul>\n";
-        $this->assertEquals( $expected, wp_generate_tag_cloud( $tags, array(
+        $found = wp_generate_tag_cloud( $tags, array(
             'hide_empty' => false,
             'format'     => 'list',
-        ) ) );
+        ) );
+
+        $this->assertRegExp( "|^<ul class='wp-tag-cloud'>|", $found );
+        $this->assertRegExp( "|</ul>\n|", $found );
+        $this->assertContains( '>' . $tags[0]->name . '<', $found );
     }
 
@@ -130 +138 @@
         ) );
 
-        $expected = "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[0]->slug}' class='tag-link-0 tag-link-position-1' title='0 topics' style='font-size: 8pt;'>{$terms[0]->name}</a>\n".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[1]->slug}' class='tag-link-1 tag-link-position-2' title='0 topics' style='font-size: 8pt;'>{$terms[1]->name}</a>\n".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[2]->slug}' class='tag-link-2 tag-link-position-3' title='0 topics' style='font-size: 8pt;'>{$terms[2]->name}</a>\n".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[3]->slug}' class='tag-link-3 tag-link-position-4' title='0 topics' style='font-size: 8pt;'>{$terms[3]->name}</a>";
-        $this->assertEquals( $expected, wp_generate_tag_cloud( $tags, array(
-            'hide_empty' => false,
-        ) ) );
+        $found = wp_generate_tag_cloud( $tags, array(
+            'hide_empty' => false,
+        ) );
+
+        foreach ( $tags as $tag ) {
+            $this->assertContains( '>' . $tag->name . '<', $found );
+        }
     }
 
@@ -152 +160 @@
         ) );
 
-        $expected = "<ul class='wp-tag-cloud'>\n\t<li>".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[0]->slug}' class='tag-link-0 tag-link-position-1' title='0 topics' style='font-size: 8pt;'>{$terms[0]->name}</a></li>\n\t<li>".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[1]->slug}' class='tag-link-1 tag-link-position-2' title='0 topics' style='font-size: 8pt;'>{$terms[1]->name}</a></li>\n\t<li>".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[2]->slug}' class='tag-link-2 tag-link-position-3' title='0 topics' style='font-size: 8pt;'>{$terms[2]->name}</a></li>\n\t<li>".
-            "<a href='http://" . WP_TESTS_DOMAIN . "/?tag={$terms[3]->slug}' class='tag-link-3 tag-link-position-4' title='0 topics' style='font-size: 8pt;'>{$terms[3]->name}</a>".
-            "</li>\n</ul>\n";
-
-        $this->assertEquals( $expected, wp_generate_tag_cloud( $tags, array(
+        $found = wp_generate_tag_cloud( $tags, array(
             'hide_empty' => false,
             'format'     => 'list',
-        ) ) );
+        ) );
+
+        $this->assertRegExp( "|^<ul class='wp-tag-cloud'>|", $found );
+        $this->assertRegExp( "|</ul>\n|", $found );
+
+        foreach ( $tags as $tag ) {
+            $this->assertContains( '>' . $tag->name . '<', $found );
+        }
     }