Changeset 36003 for trunk/tests/phpunit/tests/term/getTerms.php

Timestamp:

12/18/2015 05:43:46 PM (6 years ago)

Author:

boonebgorges

Message:

Ensure get_terms() results are unique when using 'meta_query'.

The introduction of 'meta_query' to get_terms() in 4.4 made it possible for
get_terms() to erroneously return duplicate results. To address the issue,
we add the DISTINCT keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.

File:

• trunk/tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/getTerms.php

@@ -1572 +1572 @@
 
     /**
+     * @ticket 35137
+     */
+    public function test_meta_query_should_not_return_duplicates() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $terms = self::factory()->term->create_many( 1, array( 'taxonomy' => 'wptests_tax' ) );
+        add_term_meta( $terms[0], 'foo', 'bar' );
+        add_term_meta( $terms[0], 'foo', 'ber' );
+
+        $found = get_terms( 'wptests_tax', array(
+            'hide_empty' => false,
+            'meta_query' => array(
+                array(
+                    'key' => 'foo',
+                    'value' => 'bur',
+                    'compare' => '!=',
+                ),
+            ),
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( array( $terms[0] ), $found );
+    }
+
+    /**
      * @ticket 14162
      */