Changeset 36016 for trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php

Timestamp:

12/19/2015 12:16:30 AM (8 years ago)

Author:

afercia

Message:

Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.

When JavaScript is off, the reorder menu item and Edit menu item links now use aria-label
attributes instead of title attributes.

Fixes #35134.

File:

• trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php

@@ -127 +127 @@
                                     'move-menu_item'
                                 );
-                            ?>" class="item-move-up"><abbr title="<?php esc_attr_e('Move up'); ?>">&#8593;</abbr></a>
+                            ?>" class="item-move-up" aria-label="<?php esc_attr_e( 'Move up' ) ?>">&#8593;</a>
                             |
                             <a href="<?php
@@ -140 +140 @@
                                     'move-menu_item'
                                 );
-                            ?>" class="item-move-down"><abbr title="<?php esc_attr_e('Move down'); ?>">&#8595;</abbr></a>
+                            ?>" class="item-move-down" aria-label="<?php esc_attr_e( 'Move down' ) ?>">&#8595;</a>
                         </span>
-                        <a class="item-edit" id="edit-<?php echo $item_id; ?>" title="<?php esc_attr_e('Edit Menu Item'); ?>" href="<?php
+                        <a class="item-edit" id="edit-<?php echo $item_id; ?>" href="<?php
                             echo ( isset( $_GET['edit-menu-item'] ) && $item_id == $_GET['edit-menu-item'] ) ? admin_url( 'nav-menus.php' ) : add_query_arg( 'edit-menu-item', $item_id, remove_query_arg( $removed_args, admin_url( 'nav-menus.php#menu-item-settings-' . $item_id ) ) );
-                        ?>"><?php _e( 'Edit Menu Item' ); ?></a>
+                        ?>" aria-label="<?php esc_attr_e( 'Edit menu item' ); ?>"><?php _e( 'Edit' ); ?></a>
                     </span>
                 </div>