Changeset 36056 for trunk/tests/phpunit/tests/term.php

Timestamp:

12/22/2015 01:50:08 AM (9 years ago)

Author:

boonebgorges

Message:

Order terms by 'name' when populating object term cache.

[34217] removed the ORDER BY clause from update_object_term_cache(), for
improved performance. But this proved to cause problems in cases where users
were expecting the results of get_the_terms() to be ordered by 'name'. Let's
revert the change for the time being, and look into more disciplined ordering
in a future release.

Props afercia.
See #28922. Fixes #35180.

File:

• trunk/tests/phpunit/tests/term.php (modified) (1 diff)

trunk/tests/phpunit/tests/term.php

@@ -618 +618 @@
 
     /**
+     * @ticket 35180
+     * @ticket 28922
+     */
+    public function test_get_the_terms_should_return_results_ordered_by_name_when_pulling_from_cache() {
+        register_taxonomy( 'wptests_tax', 'post' );
+        $p = self::$post_ids[0];
+
+        $t1 = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax', 'name' => 'fff' ) );
+        $t2 = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax', 'name' => 'aaa' ) );
+        $t3 = self::factory()->term->create( array( 'taxonomy' => 'wptests_tax', 'name' => 'zzz' ) );
+
+        wp_set_object_terms( $p, array( $t1, $t2, $t3 ), 'wptests_tax' );
+        update_object_term_cache( $p, 'post' );
+
+        $found = get_the_terms( $p, 'wptests_tax' );
+
+        $this->assertSame( array( $t2, $t1, $t3 ), wp_list_pluck( $found, 'term_id' ) );
+    }
+
+    /**
      * @ticket 19205
      */