Changeset 36092

Timestamp:

12/26/2015 12:47:35 AM (9 years ago)

Author:

SergeyBiryukov

Message:

Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.

This data is redundant, as the same information is already conveyed by the text hidden with .screen-reader-text class.

Props afercia.
Fixes #35141.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-plugin-install-list-table.php (modified) (1 diff)
• includes/plugin-install.php (modified) (1 diff)
• includes/template.php (modified) (2 diffs)
• theme-install.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -527 +527 @@
                 <div class="vers column-rating">
                     <?php wp_star_rating( array( 'rating' => $plugin['rating'], 'type' => 'percent', 'number' => $plugin['num_ratings'] ) ); ?>
-                    <span class="num-ratings">(<?php echo number_format_i18n( $plugin['num_ratings'] ); ?>)</span>
+                    <span class="num-ratings" aria-hidden="true">(<?php echo number_format_i18n( $plugin['num_ratings'] ); ?>)</span>
                 </div>
                 <div class="column-updated">

trunk/src/wp-admin/includes/plugin-install.php

@@ -573 +573 @@
         <h3><?php _e( 'Average Rating' ); ?></h3>
         <?php wp_star_rating( array( 'rating' => $api->rating, 'type' => 'percent', 'number' => $api->num_ratings ) ); ?>
-        <small><?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ), number_format_i18n( $api->num_ratings ) ); ?></small>
+        <small aria-hidden="true"><?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ), number_format_i18n( $api->num_ratings ) ); ?></small>
         <?php }
 

trunk/src/wp-admin/includes/template.php

@@ -9 +9 @@
  */
 
-/** Walker_Category_Checklist class */ 
+/** Walker_Category_Checklist class */
 require_once( ABSPATH . 'wp-admin/includes/class-walker-category-checklist.php' );
 
-/** WP_Internal_Pointers class */ 
+/** WP_Internal_Pointers class */
 require_once( ABSPATH . 'wp-admin/includes/class-wp-internal-pointers.php' );
 
@@ -2055 +2055 @@
     }
 
-    $output = '<div class="star-rating" title="' . esc_attr( $title ) . '">';
+    $output = '<div class="star-rating">';
     $output .= '<span class="screen-reader-text">' . $title . '</span>';
     $output .= str_repeat( '<div class="star star-full"></div>', $full_stars );

trunk/src/wp-admin/theme-install.php

@@ -260 +260 @@
                         <div class="theme-rating">
                             {{{ data.stars }}}
-                            <span class="num-ratings">({{ data.num_ratings }})</span>
+                            <span class="num-ratings" aria-hidden="true">({{ data.num_ratings }})</span>
                         </div>
                     <# } else { #>