Changeset 36125

Timestamp:

12/30/2015 11:19:11 PM (11 years ago)

Author:

swissspidy

Message:

Comments: Don't nofollow links within the site.

Fixes #11360.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (1 diff)
• tests/phpunit/tests/formatting/WPRelNoFollow.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -2337 +2337 @@
         $text = $matches[1];
         $atts = shortcode_parse_atts( $matches[1] );
-        $rel = 'nofollow';
+        $rel  = 'nofollow';
+
+        if ( preg_match( '%href=["\'](' . preg_quote( set_url_scheme( home_url(), 'http' ) ) . ')%i', $text ) ||
+             preg_match( '%href=["\'](' . preg_quote( set_url_scheme( home_url(), 'https' ) ) . ')%i', $text )
+        ) {
+                return "<a $text>";
+        }
+
         if ( ! empty( $atts['rel'] ) ) {
                 $parts = array_map( 'trim', explode( ' ', $atts['rel'] ) );

trunk/tests/phpunit/tests/formatting/WPRelNoFollow.php

@@ -23 +23 @@
                 $this->assertEquals( $expected, wp_rel_nofollow( $content ) );
         }
+
+        /**
+         * @ticket 11360
+         * @dataProvider data_wp_rel_nofollow
+         */
+        public function test_wp_rel_nofollow( $input, $output ) {
+                return $this->assertEquals( wp_slash( $output ), wp_rel_nofollow( $input ) );
+        }
+
+        public function data_wp_rel_nofollow() {
+                $home_url_http  = set_url_scheme( home_url(), 'http' );
+                $home_url_https = set_url_scheme( home_url(), 'https' );
+
+                return array(
+                        array(
+                                '<a href="">Double Quotes</a>',
+                                '<a href="" rel="nofollow">Double Quotes</a>',
+                        ),
+                        array(
+                                '<a href="https://wordpress.org">Double Quotes</a>',
+                                '<a href="https://wordpress.org" rel="nofollow">Double Quotes</a>',
+                        ),
+                        array(
+                                "<a href='https://wordpress.org'>Single Quotes</a>",
+                                "<a href='https://wordpress.org' rel=\"nofollow\">Single Quotes</a>",
+                        ),
+                        array(
+                                '<a href="https://wordpress.org" title="Title">Multiple attributes</a>',
+                                '<a href="https://wordpress.org" title="Title" rel="nofollow">Multiple attributes</a>',
+                        ),
+                        array(
+                                '<a title="Title" href="https://wordpress.org">Multiple attributes</a>',
+                                '<a title="Title" href="https://wordpress.org" rel="nofollow">Multiple attributes</a>',
+                        ),
+                        array(
+                                '<a data-someflag href="https://wordpress.org">Multiple attributes</a>',
+                                '<a data-someflag href="https://wordpress.org" rel="nofollow">Multiple attributes</a>',
+                        ),
+                        array(
+                                '<a  data-someflag  title="Title"  href="https://wordpress.org" onclick=""  >Everything at once</a>',
+                                '<a  data-someflag  title="Title"  href="https://wordpress.org" onclick=""   rel="nofollow">Everything at once</a>',
+                        ),
+                        array(
+                                '<a href="' . $home_url_http . '/some-url">Home URL (http)</a>',
+                                '<a href="' . $home_url_http . '/some-url">Home URL (http)</a>',
+                        ),
+                        array(
+                                '<a href="' . $home_url_https . '/some-url">Home URL (https)</a>',
+                                '<a href="' . $home_url_https . '/some-url">Home URL (https)</a>',
+                        ),
+                );
+        }
 }