Changeset 36137

Timestamp:

12/31/2015 11:51:09 AM (11 years ago)

Author:

afercia

Message:

Admin: Restore the "Show advanced menu properties" checkboxes IDs.

These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.

Fixes #35112 for trunk.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-screen.php (modified) (2 diffs)
• js/postbox.js (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -999 +999 @@
                  *
                  * @since 4.4.0
-                 * 
+                 *
                  * @param bool      $show_button Whether to show Screen Options submit button.
                  *                               Default false.
@@ -1088 +1088 @@
                         $id = "$column-hide";
                         echo '<label>';
-                        echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
+                        echo '<input class="hide-column-tog" name="' . $id . '" type="checkbox" id="' . $id . '" value="' . $column . '"' . checked( ! in_array( $column, $hidden ), true, false ) . ' />';
                         echo "$title</label>\n";
                 }

trunk/src/wp-admin/js/postbox.js

@@ -51 +51 @@
                         this.init( page, args );
 
-                        $handles.on( 'click.postboxes',  this.handle_click );
+                        $handles.on( 'click.postboxes', this.handle_click );
 
                         $('.postbox .hndle a').click( function(e) {
@@ -158 +158 @@
 
                 save_state : function(page) {
-                        var closed = $('.postbox').filter('.closed').map(function() { return this.id; }).get().join(','),
-                                hidden = $('.postbox').filter(':hidden').map(function() { return this.id; }).get().join(',');
+                        var closed, hidden;
+
+                        // Return on the nav-menus.php screen, see #35112.
+                        if ( 'nav-menus' === page ) {
+                                return;
+                        }
+
+                        closed = $( '.postbox' ).filter( '.closed' ).map( function() { return this.id; } ).get().join( ',' );
+                        hidden = $( '.postbox' ).filter( ':hidden' ).map( function() { return this.id; } ).get().join( ',' );
 
                         $.post(ajaxurl, {